slice: Fix crash caused by use-after-free#13113
Merged
Merged
Conversation
bneradt
approved these changes
Apr 22, 2026
Member
Author
|
[approve ci autest 2] |
Contributor
|
Cherry-picked to 10.2.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Apr 23, 2026
(cherry picked from commit 0eac5a1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin crashes if when it calls
TSHttpTxnEffectiveUrlStringGetbecausetxnpcan be freed and invalid. It happens because thetxnp(=HttpSM) may be destroyed while the plugin processes the upstream data, if the client closes the connection early.The
txnpis only used for getting an URL on the race condition. This PR change theDatastructure to keep the URL (string) instead of a pointer fortxnp. No need to worry about the lifetime.The
txnpinDatastructure and the race have been there since the beginning, but the issues was introduced by #11618.