cripts: build against fmt 11+ (incl. 12.x)#13375
Open
zwoop wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Cripts’ fmt usage to remain compatible with fmt 11+ header layout changes by switching to fmt/format.h and simplifying formatting calls in the Instance debug helper.
Changes:
- Replace
#include <fmt/core.h>with#include <fmt/format.h>in Cripts public headers. - Switch
Instance::debug()fromfmt::vformat(fmt::make_format_args(...))tofmt::format(...).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| include/cripts/Preamble.hpp | Switch fmt include to fmt/format.h for fmt 11+ compatibility. |
| include/cripts/Lulu.hpp | Switch fmt include to fmt/format.h for fmt 11+ compatibility. |
| include/cripts/Instance.hpp | Use fmt::format in Instance::debug() to avoid deprecated/removed vformat usage. |
fmt 11 dropped fmt::format/vformat from fmt/core.h; include fmt/format.h instead, and use fmt::format directly to avoid a deprecated format_string conversion. Still builds on fmt 8.1+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmt 11 dropped fmt::format/vformat from fmt/core.h; include fmt/format.h instead, and use fmt::format directly to avoid a deprecated format_string conversion. Still builds on fmt 8.1+.