Skip to content

CMake: use new policies for Highway#13414

Open
bneradt wants to merge 1 commit into
apache:masterfrom
bneradt:cmake-highway-policy-warnings
Open

CMake: use new policies for Highway#13414
bneradt wants to merge 1 commit into
apache:masterfrom
bneradt:cmake-highway-policy-warnings

Conversation

@bneradt

@bneradt bneradt commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

CMake 4.3 reports three policy warnings while configuring bundled
Highway. Each exposes compatibility behavior that makes configuration
less deterministic or defers failures.

The warnings and fixes are:

  • CMP0111 OLD behavior is deprecated: Highway’s GTest workaround
    allows an imported target without a location to produce unusable
    build rules. ATS disables Highway tests, so this selects NEW and
    makes any incomplete imported target fail during generation.

  • CMP0075 is not set: Highway’s header checks ignore inherited
    CMAKE_REQUIRED_LIBRARIES under OLD behavior. ATS also leaves OpenSSL
    libraries and includes in the probe state after TLS checks. This
    selects NEW and removes those OpenSSL values before generic checks,
    so required libraries are honored without leaking TLS dependencies.

  • CMP0077 is not set: Highway’s option(BUILD_SHARED_LIBS) discards
    the normal value supplied by ATS under OLD behavior. This selects
    NEW to preserve the parent setting while HWY_FORCE_STATIC_LIBS keeps
    bundled Highway static.

Copilot AI review requested due to automatic review settings July 21, 2026 17:40
@bneradt bneradt added this to the 11.0.0 milestone Jul 21, 2026
@bneradt bneradt self-assigned this Jul 21, 2026
@bneradt bneradt added CMake work related to CMakes scripts or issues Build work related to build configuration or environment labels Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bneradt
bneradt force-pushed the cmake-highway-policy-warnings branch from 221ae3c to a0b222d Compare July 21, 2026 17:45
CMake 4.3 reports three policy warnings while configuring bundled
Highway. Each exposes compatibility behavior that makes configuration
less deterministic or defers failures.

The warnings and fixes are:

* `CMP0111 OLD behavior is deprecated`: Highway’s GTest workaround
  allows an imported target without a location to produce unusable
  build rules. ATS disables Highway tests, so this selects NEW and
  makes any incomplete imported target fail during generation.

* `CMP0075 is not set`: Highway’s header checks ignore inherited
  CMAKE_REQUIRED_LIBRARIES under OLD behavior. ATS also leaves OpenSSL
  libraries and includes in the probe state after TLS checks. This
  selects NEW and removes those OpenSSL values before generic checks,
  so required libraries are honored without leaking TLS dependencies.

* `CMP0077 is not set`: Highway’s option(BUILD_SHARED_LIBS) discards
  the normal value supplied by ATS under OLD behavior. This selects
  NEW to preserve the parent setting while HWY_FORCE_STATIC_LIBS keeps
  bundled Highway static.
Copilot AI review requested due to automatic review settings July 21, 2026 17:50
@bneradt
bneradt force-pushed the cmake-highway-policy-warnings branch from a0b222d to 6d946c3 Compare July 21, 2026 17:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment CMake work related to CMakes scripts or issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants