Logging: add cache freshness fields#13417
Conversation
Cache modeling cannot currently observe an object’s effective freshness limit or its age when ATS serves it, leaving access logs unable to describe cache lifetime and churn. This adds cfl and cca log fields and records their values when ATS prepares cache metadata or serves a cached response. It resets the values for each lookup and adds replay coverage for writes, hits, and non-cacheable responses. Fixes: apache#13127 Co-authored-by: sheikh-saifi <p240592@pwr.nu.edu.pk>
ab8b85a to
fed4605
Compare
|
Thanks for fixing this! the reset in DecideCacheLookup and splitting the write vs hit call sites was exactly what my version was missing. Went through the code and the three test cases (write/hit/uncacheable) and it all makes sense. |
Sounds good. Thanks for the comments. I definitely plan to attribute your work with the commit, in addition to the PR here. |
Cache modeling cannot currently observe an object’s effective
freshness limit or its age when ATS serves it, leaving access logs
unable to describe cache lifetime and churn.
This adds cfl and cca log fields and records their values when ATS
prepares cache metadata or serves a cached response. It resets the
values for each lookup and adds replay coverage for writes, hits, and
non-cacheable responses.
Fixes: #13127
Co-authored-by: sheikh-saifi p240592@pwr.nu.edu.pk