Fix JSON-RPC request size check - #13430
Open
bneradt wants to merge 1 commit into
Open
Conversation
Unsigned subtraction can wrap after the JSON-RPC request buffer grows past its configured maximum. This allows oversized requests to be accepted. This compares stored bytes directly with the limit and adds regression coverage for an oversized request. Fixes: apache#12312
JosiahWI
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsigned subtraction can wrap after the JSON-RPC request buffer grows
past its configured maximum. This allows oversized requests to be
accepted.
This compares stored bytes directly with the limit and adds regression
coverage for an oversized request.
Fixes: #12312