Fix ssl_multicert.yaml usage in two 10.2.x autests - #13448
Merged
cmcfarlen merged 1 commit intoJul 29, 2026
Conversation
JosiahWI
approved these changes
Jul 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two AuTest gold tests on the 10.2.x branch that currently fail at import/load time by switching them from the unavailable ssl_multicert.yaml Disk API to the branch-supported ssl_multicert.config format and Disk API.
Changes:
- Convert
tls_secret_update_default.test.pyto writessl_multicert.configentries and touch the correct file for reload. - Convert
http2_max_active_streams.test.pyto writessl_multicert.configentries instead of YAML. - Keep the changes scoped to test configuration (no product-code changes).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/gold_tests/tls/tls_secret_update_default.test.py | Switch multicert setup + reload touch from YAML to ssl_multicert.config format for 10.2.x AuTest harness compatibility. |
| tests/gold_tests/h2/http2_max_active_streams.test.py | Replace YAML multicert setup with a single ssl_multicert.config line to avoid missing Disk API on 10.2.x. |
http2_max_active_streams and tls_secret_update_default used the ssl_multicert.yaml Disk API, which the 10.2.x autest harness does not provide -- it registers ssl_multicert.config -- so both tests threw AttributeError at load time. Convert them to the flat ssl_multicert.config form already used by other tests on the branch. For tls_secret_update_default this also updates the reload touch target and the diags.log wait condition, which looked for "ssl_multicert.yaml finished loading"; on 10.2.x the SSL loader logs the actual filename (ssl_multicert.config), so the reload wait would otherwise never become ready. These tests were backported (via apache#13386 and apache#13342) without adapting their config-file format to the release branch.
cmcfarlen
force-pushed
the
10.2.x-fix-ssl-multicert-tests
branch
from
July 29, 2026 14:51
116735a to
8f0ff34
Compare
JosiahWI
approved these changes
Jul 29, 2026
bneradt
approved these changes
Jul 29, 2026
Contributor
|
[approve ci autest 1] |
Contributor
Author
|
The failing test is fixed in another PR so I'm going to merge this and confirm the other PR is clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two autests fail at load time on
10.2.xbecause they use thessl_multicert.yamlDisk API, which the release-branch autest harnessdoes not provide (it registers
ssl_multicert.config):gold_tests/h2/http2_max_active_streams.test.pygold_tests/tls/tls_secret_update_default.test.pyBoth raise
AttributeError: 'Disk' object has no attribute 'ssl_multicert_yaml'before running. They were backported (via #13386and #13342) without adapting the config-file format to
10.2.x.This converts both to the flat
ssl_multicert.configform already usedthroughout the branch (e.g.
h2origin.test.py,tls_check_dual_cert_selection2.test.py), including the reloadtouchin the TLS test. No product-code changes.