Skip to content

Avoid stale H2 writes after 100 Continue #13504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmcfarlen merged 1 commit into from
Aug 7, 2026
+8 −3
Merged

Avoid stale H2 writes after 100 Continue #13504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/proxy/http2/Http2Stream.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,12 +807,12 @@ Http2Stream::restart_sending()
}
}

IOBufferReader *reader = this->get_data_reader_for_send();
if (reader && !reader->is_read_avail_more_than(0)) {
if (this->write_vio.mutex && this->write_vio.ntodo() <= 0) {
return;
}

if (this->write_vio.mutex && this->write_vio.ntodo() == 0) {
IOBufferReader *reader = this->get_data_reader_for_send();
if (reader && !reader->is_read_avail_more_than(0)) {
return;
}

Expand Down Expand Up @@ -970,6 +970,11 @@ Http2Stream::signal_write_event(int event, bool call_update)
write_event = nullptr;
}
_timeout.update_inactivity();
if (event == VC_EVENT_WRITE_COMPLETE) {
// HttpSM owns the write buffer and may release it while handling this
// event. Drop the unowned alias before transferring control.
_send_reader = nullptr;
}
this->write_vio.cont->handleEvent(event, &this->write_vio);
} else {
if (this->_write_vio_event) {
Expand Down