Fix for "tr-pass" handling - #1470
Closed
ykopel wants to merge 12 commits into
Closed
Conversation
Fix for 497e475
Fix for "tr-pass handling
Avoid forcing "proxied URL" in case of transparent request #1448
is_transparent_passthrough_allowed always returns false
Revert "is_transparent_passthrough_allowed always returns false"
Revert "Avoid forcing "proxied URL" in case of transparent request #1448"
Revert "Fix for "tr-pass handling"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit of 497e475
Caused to all the cases that will go into this "if" to be bypassed.
I commented there:
These lines will cause each request to fall to passthrough bypass:
This is because ua_raw_buffer_reader->read_avail() always will be grater than zero.
You haven't see it until now because of another bug (ykopel@5817738) that cause is_transparent_passthrough_allowed() to be always false and this for it never reached to your lines.
This is why I suggest to just delete them meantime.