Skip to content

Fix for "tr-pass" handling - #1470

Closed
ykopel wants to merge 12 commits into
apache:masterfrom
ykopel:master
Closed

Fix for "tr-pass" handling#1470
ykopel wants to merge 12 commits into
apache:masterfrom
ykopel:master

Conversation

@ykopel

@ykopel ykopel commented Feb 19, 2017

Copy link
Copy Markdown
Contributor

The commit of 497e475
Caused to all the cases that will go into this "if" to be bypassed.
I commented there:

These lines will cause each request to fall to passthrough bypass:

   // If we had a GET request that has data after the
   // get request, do blind tunnel
    } else if (state == PARSE_DONE &&
               t_state.hdr_info.client_request.method_get_wksidx() == 
               HTTP_WKSIDX_GET &&
               ua_raw_buffer_reader->read_avail() > 0 &&
               !t_state.hdr_info.client_request.is_keep_alive_set()) {
      do_blind_tunnel = true;
    }

This is because ua_raw_buffer_reader->read_avail() always will be grater than zero.
You haven't see it until now because of another bug (ykopel@5817738) that cause is_transparent_passthrough_allowed() to be always false and this for it never reached to your lines.
This is why I suggest to just delete them meantime.

@ykopel ykopel changed the title Fix for tr-pass handling Fix for "tr-pass" handling Feb 19, 2017
@ykopel ykopel closed this Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant