Remove start_HttpProxyServerBackDoor.#4866
Merged
SolidWallOfCode merged 1 commit intoapache:masterfrom Jan 25, 2019
Merged
Conversation
zwoop
approved these changes
Jan 25, 2019
Contributor
zwoop
left a comment
zwoop
left a comment
There was a problem hiding this comment.
Yes, sounds right. It's possible we kept it, because in theory, someone could use the synthetic URL for having e.g. SLBs health-checking the running ATS server as well (just like traffic_cop used to do).
I'm +1 on nuking this, plenty of better ways to do health checks without this crazy backdoor.
Member
Author
|
As far as I can tell, there's not backdoor anyway, this never gets called to set it up. |
Contributor
|
This change depends on another PR: |
elsloo
added a commit
to elsloo/trafficserver
that referenced
this pull request
Apr 13, 2022
* Majority of code was removed in apache#4866 * `--proxyBackDoor` argument removed from `traffic_manager` in apache#3609
elsloo
added a commit
that referenced
this pull request
Apr 18, 2022
zwoop
pushed a commit
that referenced
this pull request
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewing local changes for 7.1 to port to 8.x, I was unable to find where this is used. I think it's debris left from the destruction of
traffic_copwhich used the backdoor to do health checks.