Skip to content

Removes remaining vestiges to the backdoor port#8793

Merged
elsloo merged 1 commit intoapache:masterfrom
elsloo:remove_backdoor_references
Apr 18, 2022
Merged

Removes remaining vestiges to the backdoor port#8793
elsloo merged 1 commit intoapache:masterfrom
elsloo:remove_backdoor_references

Conversation

@elsloo
Copy link
Copy Markdown
Contributor

@elsloo elsloo commented Apr 13, 2022

@elsloo
Removes remaining vestiges to the backdoor port
0b842fa 
* Majority of code was removed in apache#4866

* `--proxyBackDoor` argument removed from `traffic_manager` in apache#3609
@elsloo elsloo added the Cleanup label Apr 13, 2022
@elsloo elsloo requested a review from bryancall as a code owner April 13, 2022 16:37
@elsloo elsloo self-assigned this Apr 13, 2022
@elsloo
Copy link
Copy Markdown
Contributor Author

elsloo commented Apr 13, 2022

I'm actually +1 on adding the backdoor back into ATS because having an avenue for tools to avoid the throttle in high load scenarios is advantageous for a number of reasons. However, these remaining vestiges to the feature creates an inconsistency that can be misleading for those reading the code and docs.

A future PR may restore this functionality, but because the code was removed in the 8.0.x timeframe, we may need further changes to restore the prior feature.

@bryancall bryancall added this to the 10.0.0 milestone Apr 18, 2022
@bryancall bryancall requested a review from bneradt April 18, 2022 23:24
@elsloo
Copy link
Copy Markdown
Contributor Author

elsloo commented Apr 18, 2022

We briefly discussed the desired mechanism to leverage for a reimplementation of the backdoor in the future during our weekly bug scrub today. We agreed that we would ideally utilize the existing paradigm of tagging ports with a desired property in proxy.config.http.server_ports (docs reference here). If we added a new keyword, for example backdoor, to the list of options, we will clearly know which port is used as a backdoor (if any), and the implementation will in theory be simpler than what we had previously due to not being tied to traffic_manager.

@elsloo elsloo merged commit fd0ca7d into apache:master Apr 18, 2022
zwoop pushed a commit that referenced this pull request Jun 15, 2022
@elsloo @zwoop
Removes remaining vestiges to the backdoor port (#8793)
4a317b5 
* Majority of code was removed in #4866

* `--proxyBackDoor` argument removed from `traffic_manager` in #3609

(cherry picked from commit fd0ca7d)
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented Jun 15, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Jun 15, 2022
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
@zwoop
Merge remote-tracking branch 'asf/9.2.x' into 9.2.x
37ff80d 
* asf/9.2.x:
  Updated ChangeLog
  Modifying array outside bounds (apache#8806)
  Add escape json for logging (apache#8886)
  Removes remaining vestiges to the backdoor port (apache#8793)
  Add Au test for prefetch plugin in simple mode. (apache#8810)
  uri_signing plugin: Fix missing payload validation for the iss field. (apache#8901)
  Cleanup SNIConfig (apache#8892)
  Fix autest uses of File exists parameter (apache#8906)
  Do not modify Transfer-Encoding header on retry (apache#8899)
  Fix plugin stats_over_http OK reason phrase (apache#8902)
  Add AuTest for stats-over-http plugin (apache#8422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bneradt bneradt bneradt approved these changes

@bryancall bryancall Awaiting requested review from bryancall

Assignees

@elsloo elsloo

Labels

Cleanup

Projects

None yet

Milestone

9.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@elsloo @zwoop @bneradt @bryancall