Add event loop timing histogram data. - #9114
Merged
Merged
Conversation
SolidWallOfCode
force-pushed
the
histogram
branch
3 times, most recently
from
September 30, 2022 15:17
2b4c6a3 to
3b6bfad
Compare
cmcfarlen
reviewed
Sep 30, 2022
SolidWallOfCode
force-pushed
the
histogram
branch
from
September 30, 2022 20:50
3b6bfad to
86ec0a5
Compare
Member
Author
|
I cleaned up the internal access quite a bit, as @cmcfarlen requested, and fixed a build error (I hope). |
SolidWallOfCode
force-pushed
the
histogram
branch
2 times, most recently
from
September 30, 2022 23:25
0ecb400 to
e442875
Compare
maskit
reviewed
Oct 3, 2022
SolidWallOfCode
force-pushed
the
histogram
branch
from
October 12, 2022 15:49
e442875 to
6dcf671
Compare
cmcfarlen
approved these changes
Oct 17, 2022
maskit
approved these changes
Oct 17, 2022
SolidWallOfCode
added a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on a problem I had at LinkedIn involving latency in requests. The event loop data looked as if the event loops were very long (billions of nanoseconds in some cases) but it wasn't possible to tell if this was the exception or the rule (i.e. is there a plugin that now and then blocks on an
ET_NETthread, or are the plugins in general slowing things up?). This adds histogram data for event loop timing so it's possible to seeThis should be backwards compatible with 9.x.
As part of this work, the
Histogramclass is added. It is designed to log samples performantly and provides a decay mechanism to keep the data relevant. These call all be adjusted by tweaking various compile time constants.