libswoc: Update to 1.4.6 - #9530
Merged
Merged
Conversation
cmcfarlen
reviewed
Mar 17, 2023
| _range._ip6.assign(min.ip6(), max.ip6()); | ||
| _family = AF_INET6; | ||
| this->assign(min.ip6(), max.ip6()); | ||
| } |
Contributor
There was a problem hiding this comment.
I know this isn't part of these changes, but should there be some assert when the families are mismatched?
Member
Author
There was a problem hiding this comment.
I don't like constructors which throw, particularly inside ATS. Instead the object should be constructed to some default / non-valid state. If this is a concern, then you should use methods (which have return values indicating what happened. A constructor like this is intended for use in situations where there's no concern about data integrity, e.g. loading predefined values.
bneradt
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPRangeSetemptyfor IP address range containersErrataformatting.