[#1206][part-2] feat(rust): introduce rust based shuffle-server - #1208
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1208 +/- ##
============================================
+ Coverage 53.74% 54.95% +1.21%
- Complexity 2598 2608 +10
============================================
Files 392 372 -20
Lines 22474 20114 -2360
Branches 1884 1884
============================================
- Hits 12078 11054 -1024
+ Misses 9688 8421 -1267
+ Partials 708 639 -69 ☔ View full report in Codecov by Sentry. |
roryqi
approved these changes
Sep 23, 2023
advancedxy
reviewed
Sep 26, 2023
| * limitations under the License. | ||
| */ | ||
|
|
||
| syntax = "proto3"; |
Contributor
There was a problem hiding this comment.
Is there any follow up prs to reuse proto file in the main repo?
Also I believe the uniffle.rs should be auto-generated rather than committed into this repo?
Member
Author
There was a problem hiding this comment.
Oh yes, I forget to delete this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rust based shuffle-server is implemented by me in riffle, it's time to contribute
back to uniffle community.
Why are the changes needed?
For #1206
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UTs