Skip to content

[#1206][part-3] chore(rust): remove the protoc auto-generated code - #1218

Merged
zuston merged 1 commit into
apache:masterfrom
zuston:removeUniffleRs
Sep 27, 2023
Merged

[#1206][part-3] chore(rust): remove the protoc auto-generated code#1218
zuston merged 1 commit into
apache:masterfrom
zuston:removeUniffleRs

Conversation

@zuston

@zuston zuston commented Sep 26, 2023

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

remove the protoc auto-generated code

Why are the changes needed?

For #1206

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs

@zuston zuston changed the title [#1206] chore(rust): remove the protoc auto-generated code [#1206][part-3] chore(rust): remove the protoc auto-generated code Sep 26, 2023
@zuston
zuston requested a review from advancedxy September 26, 2023 11:13
@codecov-commenter

codecov-commenter commented Sep 26, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1218 (ba97151) into master (b4adaa5) will increase coverage by 1.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1218      +/-   ##
============================================
+ Coverage     53.75%   54.87%   +1.12%     
- Complexity     2600     2602       +2     
============================================
  Files           392      372      -20     
  Lines         22486    20126    -2360     
  Branches       1887     1887              
============================================
- Hits          12087    11045    -1042     
+ Misses         9689     8444    -1245     
+ Partials        710      637      -73     

see 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@advancedxy

Copy link
Copy Markdown
Contributor

is it possible to soft link the proto file in the parent dir? I don’t think we need two proto files.

@zuston

zuston commented Sep 27, 2023

Copy link
Copy Markdown
Member Author

is it possible to soft link the proto file in the parent dir? I don’t think we need two proto files.

It's OK for me. Let's do this in another PR. If you are interested, feel free to take this.

@advancedxy

Copy link
Copy Markdown
Contributor

is it possible to soft link the proto file in the parent dir? I don’t think we need two proto files.

It's OK for me. Let's do this in another PR. If you are interested, feel free to take this.

Sounds good to me. Let's create an issue to track this then.

I'm quite busy these days, not sure I have the time to work on this.

@zuston
zuston merged commit eb7a1db into apache:master Sep 27, 2023
zuston added a commit that referenced this pull request Oct 12, 2023
### What changes were proposed in this pull request?

Follow up #1218 

### Why are the changes needed?

For #1206 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Needn't
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants