Skip to content

[#1206] chore(rust): ignore generated proto code in git - #1229

Merged
zuston merged 1 commit into
masterfrom
1206
Oct 12, 2023
Merged

[#1206] chore(rust): ignore generated proto code in git#1229
zuston merged 1 commit into
masterfrom
1206

Conversation

@zuston

@zuston zuston commented Oct 10, 2023

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Follow up #1218

Why are the changes needed?

For #1206

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Needn't

@codecov-commenter

codecov-commenter commented Oct 10, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1229 (0f14e85) into master (05aba70) will decrease coverage by 0.33%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1229      +/-   ##
============================================
- Coverage     54.60%   54.28%   -0.33%     
- Complexity     2606     2668      +62     
============================================
  Files           372      375       +3     
  Lines         20186    20885     +699     
  Branches       1925     2082     +157     
============================================
+ Hits          11023    11337     +314     
- Misses         8502     8867     +365     
- Partials        661      681      +20     

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@zuston
zuston merged commit 77092e4 into master Oct 12, 2023
@roryqi
roryqi deleted the 1206 branch October 23, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants