[#1091] refactor: Refactor the writer code with builder pattern - #1228
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
============================================
+ Coverage 53.48% 54.79% +1.31%
- Complexity 2613 2625 +12
============================================
Files 395 375 -20
Lines 22584 20288 -2296
Branches 1930 1933 +3
============================================
- Hits 12078 11117 -961
+ Misses 9771 8501 -1270
+ Partials 735 670 -65
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
changed the title
This was referenced Dec 28, 2023
roryqi
pushed a commit
that referenced
this pull request
Jan 2, 2024
### What changes were proposed in this pull request? Fix a bug that was introduced from [#1228](#1228). When the RssConf variable is not null, it gets overridden by a new RssConf, resulting in the loss of existing parameters within RssConf. ### Why are the changes needed? For [#1403](#1403) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By setting RSS client configs successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As the title
Why are the changes needed?
#1091
Does this PR introduce any user-facing change?
No.
How was this patch tested?
unit test