[#1409] fix(client): Netty Epoll is unavailable for the RSS Client. - #1410
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1410 +/- ##
============================================
+ Coverage 53.24% 54.16% +0.92%
- Complexity 2719 2720 +1
============================================
Files 419 399 -20
Lines 23966 21605 -2361
Branches 2042 2042
============================================
- Hits 12760 11702 -1058
+ Misses 10418 9187 -1231
+ Partials 788 716 -72 ☔ View full report in Codecov by Sentry. |
rickyma
force-pushed
the
shade-netty-native-libraries
branch
from
December 29, 2023 17:49
8784a89 to
3192573
Compare
Contributor
Author
|
PTAL @jerqi |
Contributor
|
What will it happen if we don't have this pr? |
Contributor
Author
|
As described in #1409, Also, a more detailed description will be: @jerqi |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What changes were proposed in this pull request?
Fix a bug that was introduced from #343.
The Netty native libraries have never been successfully shaded. PR #924 is not working at all.
Why are the changes needed?
For #1409
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the RSS Netty client with Epoll mode successfully.