Skip to content

[#1409] fix(client): Netty Epoll is unavailable for the RSS Client. - #1410

Merged
roryqi merged 1 commit into
apache:masterfrom
rickyma:shade-netty-native-libraries
Jan 2, 2024
Merged

[#1409] fix(client): Netty Epoll is unavailable for the RSS Client.#1410
roryqi merged 1 commit into
apache:masterfrom
rickyma:shade-netty-native-libraries

Conversation

@rickyma

@rickyma rickyma commented Dec 29, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Fix a bug that was introduced from #343.
The Netty native libraries have never been successfully shaded. PR #924 is not working at all.

Why are the changes needed?

For #1409

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By running the RSS Netty client with Epoll mode successfully.

@codecov-commenter

codecov-commenter commented Dec 29, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (995ed46) 53.24% compared to head (3192573) 54.16%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1410      +/-   ##
============================================
+ Coverage     53.24%   54.16%   +0.92%     
- Complexity     2719     2720       +1     
============================================
  Files           419      399      -20     
  Lines         23966    21605    -2361     
  Branches       2042     2042              
============================================
- Hits          12760    11702    -1058     
+ Misses        10418     9187    -1231     
+ Partials        788      716      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickyma
rickyma force-pushed the shade-netty-native-libraries branch from 8784a89 to 3192573 Compare December 29, 2023 17:49
@rickyma

rickyma commented Dec 29, 2023

Copy link
Copy Markdown
Contributor Author

PTAL @jerqi

@roryqi

roryqi commented Jan 1, 2024

Copy link
Copy Markdown
Contributor

What will it happen if we don't have this pr?

@rickyma

rickyma commented Jan 2, 2024

Copy link
Copy Markdown
Contributor Author

As described in #1409, java.lang.UnsatisfiedLinkError will be thrown.

Also, a more detailed description will be:

before this PR:
企业微信截图_17038454422572

after this PR:
企业微信截图_17041644063233

@jerqi

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rickyma , merged to master.

@roryqi
roryqi merged commit 9ebda60 into apache:master Jan 2, 2024
@rickyma
rickyma deleted the shade-netty-native-libraries branch May 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants