ZOOKEEPER-1580:QuorumPeer.setRunning is not used #446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmolnar
requested changes
Jan 9, 2018
| } | ||
|
|
||
| public void setRunning(boolean running) { | ||
| private void setRunning(boolean running) { |
Contributor
There was a problem hiding this comment.
I can't see the point of using a private setter. Set the field directly instead.
Member
Author
There was a problem hiding this comment.
I'm also ambiguous about this change.could you give me some your insight?
Contributor
Contributor
There was a problem hiding this comment.
Sorry for the late answer. It's not too much of an insight, rather - in general - I don't see the point of using a private setter without logic. In other words, is there any objection against setting the field directly?
Contributor
There was a problem hiding this comment.
+1 to @anmolnar i think we can remote the setter
afine
requested changes
Jan 23, 2018
| } | ||
|
|
||
| public void setRunning(boolean running) { | ||
| private void setRunning(boolean running) { |
Contributor
There was a problem hiding this comment.
+1 to @anmolnar i think we can remote the setter
…data This bug is caused by an issue in our file padding logic. We calculate an incorrect position to add padding when appending to the transaction log, this often corrupts a transaction. When the log is read the CRC check will correctly fail. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes apache#436 from afine/ZOOKEEPER-2249 and squashes the following commits: f3bc06c [Abraham Fine] Improve testing and respond to phunt's comment 44ad057 [Abraham Fine] ZOOKEEPER-2249: CRC check failed when preAllocSize smaller than node data Change-Id: Id8ba9ad730760cb78672127b8c0e02db60b4e87d
This test relies on hooking into our logging system and creates a new appender using a PatternLayout object shared with the CONSOLE appender. PatternLayout has some synchronization issues (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html) so we should create a new instance of it. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes apache#437 from afine/ZOOKEEPER-2961_master Change-Id: I1c81d37b94b12e0721a671deb2fc983773f88fd9
See [https://issues.apache.org/jira/browse/ZOOKEEPER-2964](url) for details. The bug affects versions newer than 3.5. According to Andor Molnar‘s [review](https://issues.apache.org/jira/browse/ZOOKEEPER-2964?focusedCommentId=16330018&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16330018) this patch can be applied to master and branch-3.5 branches. Thanks all for reviewing this issue. Author: Qihong Xu <qihongxu@bu.edu> Reviewers: phunt@apache.org Closes apache#449 from qihongxu/ZOOKEEPER-2964 Change-Id: Ie7de251afd5cca64f4735d75d9c95a886ff75328
asfgit
pushed a commit
that referenced
this pull request
Jan 30, 2018
- more details in [JIRA:ZOOKEEPER-1580](https://issues.apache.org/jira/browse/ZOOKEEPER-1580) - I forget fetching the upstream codes, make a mistake in the origin [PR-446] (#446) which includes some review history,so I close it and open a new one Author: maoling <maoling199210191@sina.com> Reviewers: Patrick Hunt <phunt@apache.org>, Andor Molnár <andor@cloudera.com>, Abraham Fine <afine@apache.org> Closes #452 from maoling/ZOOKEEPER-1580 and squashes the following commits: 29a5aba [maoling] remove the setter and return back to setting the running field directly 28de1e8 [maoling] ZOOKEEPER-1580:QuorumPeer.setRunning is not used
asfgit
pushed a commit
that referenced
this pull request
Jan 30, 2018
- more details in [JIRA:ZOOKEEPER-1580](https://issues.apache.org/jira/browse/ZOOKEEPER-1580) - I forget fetching the upstream codes, make a mistake in the origin [PR-446] (#446) which includes some review history,so I close it and open a new one Author: maoling <maoling199210191@sina.com> Reviewers: Patrick Hunt <phunt@apache.org>, Andor Molnár <andor@cloudera.com>, Abraham Fine <afine@apache.org> Closes #452 from maoling/ZOOKEEPER-1580 and squashes the following commits: 29a5aba [maoling] remove the setter and return back to setting the running field directly 28de1e8 [maoling] ZOOKEEPER-1580:QuorumPeer.setRunning is not used (cherry picked from commit d1b07d5) Signed-off-by: Abraham Fine <afine@apache.org>
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
- more details in [JIRA:ZOOKEEPER-1580](https://issues.apache.org/jira/browse/ZOOKEEPER-1580) - I forget fetching the upstream codes, make a mistake in the origin [PR-446] (apache#446) which includes some review history,so I close it and open a new one Author: maoling <maoling199210191@sina.com> Reviewers: Patrick Hunt <phunt@apache.org>, Andor Molnár <andor@cloudera.com>, Abraham Fine <afine@apache.org> Closes apache#452 from maoling/ZOOKEEPER-1580 and squashes the following commits: 29a5aba [maoling] remove the setter and return back to setting the running field directly 28de1e8 [maoling] ZOOKEEPER-1580:QuorumPeer.setRunning is not used
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
- more details in [JIRA:ZOOKEEPER-1580](https://issues.apache.org/jira/browse/ZOOKEEPER-1580) - I forget fetching the upstream codes, make a mistake in the origin [PR-446] (apache#446) which includes some review history,so I close it and open a new one Author: maoling <maoling199210191@sina.com> Reviewers: Patrick Hunt <phunt@apache.org>, Andor Molnár <andor@cloudera.com>, Abraham Fine <afine@apache.org> Closes apache#452 from maoling/ZOOKEEPER-1580 and squashes the following commits: 29a5aba [maoling] remove the setter and return back to setting the running field directly 28de1e8 [maoling] ZOOKEEPER-1580:QuorumPeer.setRunning is not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more details in JIRA:ZOOKEEPER-1580