fix: don't listen on every interface in createTunnel - #675
Merged
Conversation
github-actions
Bot
added
t-unblocking
VojtaM39
marked this pull request as draft
August 24, 2026 16:39
jancurn
approved these changes
Aug 24, 2026
VojtaM39
marked this pull request as ready for review
August 25, 2026 06:15
bliuchak
approved these changes
Aug 26, 2026
Contributor
|
@jirimoravcik could you please take a look at it (just in case we're not missing something)? 🙏 |
jirimoravcik
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createTunnel()calledserver.listen(0)without a host, so the tunnel bound theunspecified address (
::/0.0.0.0). Any peer that could reach the host could tunnelto
targetHostusing those credentials.GHSA-5vwf-g8jp-pgj3, #660.
Changes:
createTunnel()listens on127.0.0.1by default. Theportandhostnameoptionsdocumented in the README work again — they were dropped from the implementation in v2.0.0.
Pass
hostname: '0.0.0.0'to opt back into the old binding.Behavior change: the returned endpoint is
127.0.0.1:<port>instead of0.0.0.0:<port>.I have also pushed a branch
tmp/tunnel-connect-fix-with-reprowith repro, that demonstrates that the fix works.