Skip to content

test: migrate tests to vitest - #676

Merged
VojtaM39 merged 7 commits into
masterfrom
chore/migrate-tests-to-vitest
Aug 26, 2026
Merged

test: migrate tests to vitest#676
VojtaM39 merged 7 commits into
masterfrom
chore/migrate-tests-to-vitest

Conversation

@VojtaM39

@VojtaM39 VojtaM39 commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR migrates tests from mocha to vitest.

Notes:

  • test files are now executed in parallel
  • chai style assertions rewritten to vitest style
  • test/utils/throws_async.js deleted => await expect(...).rejects.toThrow(...)
  • throws_async was called without await from sync it() bodies - these could not fail
  • adds node 26 to the unit test matrix

@github-actions github-actions Bot added t-unblocking Issues with this label are in the ownership of the unblocking team. tested Temporary label used only programatically for some analytics. labels Aug 25, 2026
@VojtaM39 VojtaM39 added the adhoc Ad-hoc unplanned task added during the sprint. label Aug 25, 2026
@VojtaM39
VojtaM39 marked this pull request as ready for review August 26, 2026 07:56
daniil-poletaev
daniil-poletaev approved these changes Aug 26, 2026
View reviewed changes

@daniil-poletaev daniil-poletaev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Comment thread test/Dockerfile Outdated
Comment thread test/README.md Outdated
bliuchak
bliuchak approved these changes Aug 26, 2026
View reviewed changes

@bliuchak bliuchak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it!

Comment thread test/e2e/http-agent.js
@bliuchak bliuchak added low priority Low priority issues to be done eventually. and removed low priority Low priority issues to be done eventually. labels Aug 26, 2026
@bliuchak

bliuchak commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@VojtaM39 fyi here we had 2193 tests (e2e) and in this PR we have just 2187.

We've "lost" 6 test cases. Is it expected?

@VojtaM39

VojtaM39 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@bliuchak the PR #675 adds 6 tests, so this is expected. The suggestion i gave IRL was not correct, we didn't remove anything here.

@VojtaM39
VojtaM39 force-pushed the chore/migrate-tests-to-vitest branch from ccd4901 to 8557f31 Compare August 26, 2026 16:02
@VojtaM39
VojtaM39 merged commit 5016682 into master Aug 26, 2026
10 checks passed
@VojtaM39
VojtaM39 deleted the chore/migrate-tests-to-vitest branch August 26, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bliuchak bliuchak bliuchak approved these changes
@daniil-poletaev daniil-poletaev daniil-poletaev approved these changes

Assignees

@VojtaM39 VojtaM39

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-unblocking Issues with this label are in the ownership of the unblocking team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

148th sprint - Unblocking team

Development

Successfully merging this pull request may close these issues.

4 participants

@VojtaM39 @bliuchak @daniil-poletaev @apify-service-account