Conversation
…s. This issue could cause a document to appear to be related to the same document more than on ce
boutell
commented
Jul 29, 2025
| <ol | ||
| @click="isSuppressingWidgetControls = false" | ||
| class="apos-area-widget__breadcrumbs" | ||
| @click="isSuppressingWidgetControls = false" |
Member
Author
There was a problem hiding this comment.
unrelated, satisfies eslint
boutell
commented
Jul 29, 2025
| post: { | ||
| upload: [ | ||
| self.canUpload, | ||
| //In the existing code, we are reading the zeroth element from the files array object, which results in processing only a single file. Therefore, I am currently reading just one file from the Multer package. |
Member
Author
There was a problem hiding this comment.
unrelated, satisfies eslint, comment is not necessary anymore
boutell
commented
Jul 29, 2025
| return attachment; | ||
| } finally { | ||
| //Hence I am reading the single file from the upload and I am checking the condtion for the same | ||
| if (req.file) { |
Member
Author
There was a problem hiding this comment.
unrelated, satisfies eslint, comment is not necessary anymore
boutell
commented
Jul 29, 2025
| getter, | ||
| idMapper | ||
| ) { | ||
| // This method never alters the items array itself, it alters |
Member
Author
There was a problem hiding this comment.
Note that reducing to unique elements in this way does not make new objects nor does it test actual object contents. This is intentional. We just want to eliminate duplicates by reference.
myovchev
approved these changes
Jul 29, 2025
haroun
added a commit
that referenced
this pull request
Jul 30, 2025
* main: Resolved an issue affecting `withRelationships` with two or more steps. This issue could cause a document to appear to be related to the same document more than on (#5015) thanks! (#5014) Fix #4979: Replace connect-multiparty with multer to resolve security vulnerability (#5013) Hide rich text controls on interaction (#5008)
haroun
added a commit
that referenced
this pull request
Jul 31, 2025
* main: PRO-8130: default node parseHTML now detects whether an element has the relevant class, or lack of one, before classifying it as a default node (#5017) Add regression tests for duplicate relationships resolution in some edge cases (#5016) Resolved an issue affecting `withRelationships` with two or more steps. This issue could cause a document to appear to be related to the same document more than on (#5015) thanks! (#5014) Fix #4979: Replace connect-multiparty with multer to resolve security vulnerability (#5013) Hide rich text controls on interaction (#5008)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue could cause a document to appear to be related to the same document more than once. If several documents in the first step of the
withRelationshipspath are related to the same document in the second step, then widgets containing relationships in the second step might populate with multiple copies of the same image.In particular: [ 'articles', 'authors' ] in apollo, where 'authors' have an area containing an image widget, and the same author was attached to several articles.