Flush embedded channel. #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: apple/swift-nio#421 changed the behaviour of EmbeddedChannel to no longer automatically succeed write promises without flushes. This is a reasonable behavioural change, but broke a test that was working around but still implicitly relied on the old behaviour. Modifications: Add the missing flushes. Result: This test will pass both on NIO master and NIO 1.7.0
weissi
approved these changes
May 22, 2018
Member
weissi
left a comment
weissi
left a comment
There was a problem hiding this comment.
that looks good, sorry for breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
apple/swift-nio#421 changed the behaviour of EmbeddedChannel to no longer
automatically succeed write promises without flushes. This is a reasonable
behavioural change, but broke a test that was working around but still
implicitly relied on the old behaviour.
Modifications:
Add the missing flushes.
Result:
This test will pass both on NIO master and NIO 1.7.0