Track Future allocations in CI. #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We don't want to regress the number of heap allocations we perform. Modifications: Added appropriate environment variables to Docker files. Result: Things go bang if we regress Future allocation counts.
normanmaurer
approved these changes
May 1, 2018
Contributor
Author
|
@swift-nio-bot test this please |
1 similar comment
Contributor
Author
|
@swift-nio-bot test this please |
Contributor
Author
|
Hrm, one of these builds is consistently failing, but which one it is changes from run to run. Any idea what's going on there @tomerd? |
Member
|
docker is hard. @swift-nio-bot test this please |
Member
|
@swift-nio-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We don't want to regress the number of heap allocations we perform.
Modifications:
Added appropriate environment variables to Docker files.
Result:
Things go bang if we regress Future allocation counts.