fewer warnings for 4.2 in 4.2 mode #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
requested review from
Lukasa and
normanmaurer
and removed request for
Lukasa
normanmaurer
approved these changes
May 16, 2018
Motivation: Minus [SR-7578](https://bugs.swift.org/browse/SR-7578) which will be fixed soon, we should then compile warning-free in `-swift-version 4` mode which is good. However, we should also be as warning-free as possible in `-swift-version 4.2`. This is not entirely possible because of `@_inlineable` vs `@inlinable` but we can address the other warnings. Modifications: - make `CountableRange` vs `Range` (which used to be separate types but are now the same) work warning-free Swift 4.[01] and Swift 4.2 Result: Fewer warnings.
weissi
force-pushed
the
jw-4.2-in-4.2-mode
branch
from
005b49b to
822a3cf
Compare
Member
Author
|
@normanmaurer ok, turns out we need both |
Member
|
@weissi before merging please adjust commit message as it still mention |
Member
Author
|
@normanmaurer thanks, fixed. Had removed it from the commit msg but not from the PR describe. Now done too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Minus SR-7578 which will be
fixed soon, we should then compile warning-free in
-swift-version 4mode which is good.
However, we should also be as warning-free as possible in
-swift-version 4.2. This is not entirely possible because of@_inlineablevs@inlinablebut we can address the other warnings.Modifications:
CountableRangevsRange(which used to be separate types butare now the same) work warning-free Swift 4.[01] and Swift 4.2
Result:
Fewer warnings.
test this the following way: