[Feature #4542] : simple nav unify api/datasource#4987
Merged
Conversation
2. Added connect buttons to em
Contributor
Author
|
@rishabhsaxena |
rishabhsaxena
previously approved these changes
Jun 29, 2021
Contributor
Author
|
Tests failed due to mock data resources are not up yet. Deployment is in progress for release BE. Will rerun the flow once the expected BE changes are up |
rishabhsaxena
previously approved these changes
Jun 30, 2021
Contributor
Author
|
/ok-to-test sha=d54734a |
Contributor
Author
|
/ok-to-test sha=1b2819f |
rishabhsaxena
previously approved these changes
Jun 30, 2021
rishabhsaxena
left a comment
rishabhsaxena
left a comment
Contributor
There was a problem hiding this comment.
nitpick: we could define common styles for the scroll bar and use them across
Contributor
|
@pranavkanade I suppose should also confirm it the api itself doesn't throw an error for self hosted instances |
rishabhsaxena
previously approved these changes
Jun 30, 2021
rishabhsaxena
approved these changes
Jun 30, 2021
pranavkanade
added a commit
that referenced
this pull request
Jul 1, 2021
This reverts commit 8d8b9ed
pranavkanade
added a commit
that referenced
this pull request
Jul 1, 2021
rishabhsaxena
added a commit
that referenced
this pull request
Jul 2, 2021
* temp commit * using onsubmit to continue using action on form * added recaptcha site key to env example file * moved the recaptcha lib loading logic to signup page * removed unnecessary edit * handle the case where the recaptcha token is not provided as env var * added proper env var config for client * recaptcha config for ansible * recaptcha config for heroku * recaptcha config for k8s * updated app.json * fixed the typos * added more description for env vars * removed api key * minor typo fix * added new integration button * updated the add int default link * added active and create new tabs * added the empty components to tabs. will control the section manually. * added proper grid for integrations page * added vertical tabs * Added secondary tabs to integrations page * added separate page for new apis * classname changes * added new components for active queries, new queries etc. * added a separate component for data source list * adding screen component conditionally, to be showing upon user's choice * 1. Added grid styling to datasource home 2. Added connect buttons to em * fixed data source security banner * updated the styling for new api page * added tertiary menu for active integrations * updated styling for active connections * updated collapse component to work properly * added show more option to active data sources * removed apis/db tabs and replaced em with integrations tab * removed the unnecessary + integrations btn * Ordered the action entries under integrations * updated the getURL with proper params * updated the link of create datasource btn * updated the back btn link from data source editor * added scrollable content to create new * added on click scroll to create new page * fixed a bug, creating new datasource twice * added new action creator for integrations. * updated the query editor to match the over all theme * updated the query editor tabs * Added the run btn to empty response screens * minor fix * updated the bg color of api type drop down * updated the url being visited after delete api/query * removed log * removed unnecessary junk from integrations editor index * clean up, removed unnecessary files * removed useless routes * for debugger only checking if integrations editor * Removed all the links for api/query home pages * not routing to integrations on create query/api * removed the query/datasource/api home pages * fixed scrolling issue * will show a list of queries and apis for action picker * showing icons for each action under integrations * added a way to list data sources in action creators * cam show icons for datasources * linked integration tab movement to URL * fixed the create new query bug * removed search * added the auto redirection mode * added new mode to support showing mock data bases * on click show more works properly * removed extra padding * removed height * showing all the data sources on active tab * fixed the creation of google sheet * updated the proper routing for curl * fixed page height * removed loader * added a spinner for creating a new api * will be showing edit/add query permanantly * updated the redirection on save and delete datasource * fixed the redirection logic on delete * will not show security banner * added empty state for active data sources * updated the hover state * minor fix to redirect on delete from entity pane * fixed a cy command to create new api * fixed a command to select api/query from lightning menu * updated the navigate to data source editor * removed add btns for new int creation * updated the testSaveDeleteDatasource command * fixed bind table text pagination spec * more test case fixes for deleting a query using context menu * update curl test * updated curl post import spec * fixed click from apis to integrations * updated execute db query command + updated delete query mech * updated CreationOfUniqueAPIcheck command * updated query datasource spec * fixed an action creator bug. * fixed curl api creation bug * removed irrelavent part of the test * fixed the button colors * updated back link from datasource page * Revert url validation changes for the debugger since this is used to check whether we are on a query or an api and show its dependencies * updated a test case to open integrations option in action selectors * Update app/client/src/pages/Editor/IntegrationEditor/DatasourceCard.tsx Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com> * separated msg * styling fixes for collapse component * renamed a file * declared a new const in theme * updated border * removed a faint line from collapse card * removed unnecessary condition * updated component name * log removed * split action creator file * updated the icon usage in action creators * can properly fetch mock data sources * can show mock databases in create new * can use mock db sources * fixed the scrollbars * updated the api icon for both global search + action creator * updated integrations name in datasources * added a back to canvas ribbon * updated query and api editor to show back to canvas ribbon * added a ribbon to go back * updated button styles * updated the action creator and test commands/classes * updates to show the proper mock databases * added proper type for mock datasources * removed unnecessary log * updated a test case to work with new nav * minor updates for tests * updated a command to properly delete a datasource * minor redirection fix * made the mock db api call unblocking * fixed scroll bars all over * fixed bg colors for back ribbons * declared a constant for thin scrollbar * removed unnecessary action. Co-authored-by: Akash N <akash@codemonk.in> Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
rishabhsaxena
pushed a commit
that referenced
this pull request
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the navigation experience of a user when creating new integrations by unifying apis/datasources tabs.
Fixes #4542
Fixes #5029
Type of change
How Has This Been Tested?
Updated existing cypress tests, which inherently test the new nav flow
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased
app/client/src/actions/collectionAction.ts75100066.67app/client/src/components/editorComponents/ActionCreator.tsx34.6723.2222.2233.68app/client/src/pages/Editor/APIEditor/ApiHomeScreen.tsx37.0424.323.5737.4app/client/src/pages/Editor/DataSourceEditor/DatasourceHome.tsx56.5252.631058.14app/client/src/pages/Editor/QueryEditor/AddDatasourceSecurely.tsx91.67100091.67app/client/src/pages/Editor/QueryEditor/DatasourceCard.tsx58.9752.94058.97app/client/src/pages/Editor/QueryEditor/QueryHomeScreen.tsx41.0742.118.3344.9