Skip to content

[Bug] Mock data section is missing#5517

Merged
pranavkanade merged 2 commits into
releasefrom
bug/show_mock_dbs_new_nav
Jul 1, 2021
Merged

[Bug] Mock data section is missing#5517
pranavkanade merged 2 commits into
releasefrom
bug/show_mock_dbs_new_nav

Conversation

@pranavkanade

@pranavkanade pranavkanade commented Jul 1, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Updated the buggy conditions to show mock data listing

Fixes #5516

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: bug/show_mock_dbs_new_nav
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.07 (0) 36.09 (0) 32.57 (0) 54.62 (0.01)
🟢 app/client/src/pages/Editor/IntegrationEditor/IntegrationsHomeScreen.tsx 30.89 (0.24) 15.15 (-0.48) 5.56 (0) 32.17 (0.27)

@pranavkanade pranavkanade self-assigned this Jul 1, 2021
@pranavkanade

pranavkanade commented Jul 1, 2021

Copy link
Copy Markdown
Contributor Author

Failing ExplorerTests/Entity_Explorer_CopyQuery_RenameDatasource_spec.js test case, although it passes locally. Will add fixes with with separate PR

@pranavkanade
pranavkanade merged commit be48f2f into release Jul 1, 2021
@pranavkanade
pranavkanade deleted the bug/show_mock_dbs_new_nav branch July 1, 2021 05:51
pranavkanade added a commit that referenced this pull request Jul 1, 2021
@pranavkanade
Revert "[Bug] Mock data section is missing (#5517)"
5ee670c 
This reverts commit be48f2f
pranavkanade added a commit that referenced this pull request Jul 1, 2021
@pranavkanade
[Fix] revert new nav (#5533)
1647815 
* Revert "[Bug] Mock data section is missing (#5517)"

This reverts commit be48f2f

* Revert "[Feature #4542] : simple nav unify api/datasource (#4987)"

This reverts commit 8d8b9ed
rishabhsaxena pushed a commit that referenced this pull request Jul 2, 2021
@pranavkanade @rishabhsaxena
[Bug] Mock data section is missing (#5517)
2999fca 
* updated the condition to show mock databases

* removed log
rishabhsaxena pushed a commit that referenced this pull request Jul 2, 2021
@pranavkanade @rishabhsaxena
[Fix] revert new nav (#5533)
a191a91 
* Revert "[Bug] Mock data section is missing (#5517)"

This reverts commit be48f2f

* Revert "[Feature #4542] : simple nav unify api/datasource (#4987)"

This reverts commit 8d8b9ed
@NandanAnantharamu
NandanAnantharamu restored the bug/show_mock_dbs_new_nav branch August 16, 2021 18:40
@hetunandu
hetunandu deleted the bug/show_mock_dbs_new_nav branch October 18, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@vihar vihar vihar approved these changes
@nayan-rafiq nayan-rafiq nayan-rafiq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pranavkanade pranavkanade

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Mock Datasources are not visible with new nav

3 participants

@pranavkanade @vihar @nayan-rafiq