Skip to content

Feature/slash commands#5523

Closed
hetunandu wants to merge 120 commits into
releasefrom
feature/slash_commands
Closed

Feature/slash commands#5523
hetunandu wants to merge 120 commits into
releasefrom
feature/slash_commands

Conversation

@hetunandu

@hetunandu hetunandu commented Jul 1, 2021

Copy link
Copy Markdown
Member

Description

Introducing slash commands, the quicker and simpler way to let users bind their widgets to a datasource. Commands can be triggered by typing "/" and it should work anywhere outside a dynamic binding. Following are the commands supported in the initial cut.

  • Command to bind to an existing action
  • Command to create a new API
  • Commands to create new query in an existing datasource

Fixes #4540

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

akash-codemonk and others added 23 commits June 17, 2021 17:55
Changed commands
* Slash commands feature init commit

* Added more commands

* Introduced JSX to render custom commands

* Merge conflict fix

* Spacing changes

* Added slash commands button

* Adjust styles for better ui

* Added new datasource command

* Minor changes to add new bindings command.
Changed ui behaviour of / button

* UI style change

* Insert binding command UI change

* More UI changes

* Move command actions to a saga
Added support to binding the data back to the widget when are new API is created from widget

* Added reverse binding for DB queries

* Show / button only on hover

* Hide actions from suggestions in action pages

* Changes widget.data to widget in slash commands

* Minor refactoring.
Changed commands

* Removed unused code
Fixed autocomplete not showing up
@rishabhsaxena

Copy link
Copy Markdown
Contributor

@akash-codemonk couple of points for the associated entities and the slash commands. Let's check if they're easy to fix.
@pranavkanade please have a look at the conflicts when you get a chance

Slash commands:

  • Mouse clicks don’t execute commands, enter key works
  • Table data renders [object object] if we directly click on slash menu, similar for chart data
Screen.Recording.2021-07-01.at.4.42.16.PM.mov

Associated entities at the property pane:

  • Associated entities don’t get reset if binding is removed
  • Icons not visible in non highlighted state

@pranavkanade

Copy link
Copy Markdown
Contributor

#5558 was used to merge these changes

@mohanarpit
mohanarpit deleted the feature/slash_commands branch July 7, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Slash commands in autocomplete

5 participants