[Feature] Unified New Nav by pranavkanade · Pull Request #5558 · appsmithorg/appsmith

pranavkanade · 2021-07-02T12:17:34Z

Description

Introduces new unified navigation flow for creating datasources/queries/apis/mock databases
Nux CTA in query pane
new / command for auto complete
New mock databases

Fixes #4542
Fixes #5029
Fixes #4962
Fixes #4545
Fixes #4540

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Cypress tests

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased

// Code coverage diff between base branch:release and head branch: feature/new-nav-complete

Status	File	% Stmts	% Branch	% Funcs	% Lines
🔴	total	53.91 (-0.25)	36.03 (-0.11)	32.64 (-0.23)	54.49 (-0.17)
🔴	app/client/src/actions/apiPaneActions.ts	67.86 (-0.14)	100 (0)	0 (0)	52.63 (-0.31)
🔴	app/client/src/actions/datasourceActions.ts	66.67 (0)	0 (0)	0 (0)	52.5 (-0.28)
🔴	app/client/src/api/DatasourcesApi.ts	62.5 (-2.5)	0 (0)	11.11 (-3.18)	60.87 (-2.29)
🟢	app/client/src/components/ads/Button.tsx	92.19 (0.78)	79.57 (0)	93.02 (2.32)	92.86 (0.8)
🟢	app/client/src/components/ads/Dropdown.tsx	64.1 (1.6)	68.13 (1.02)	36.84 (0)	61.11 (2.02)
🟢	app/client/src/components/ads/Icon.tsx	57.52 (0.21)	42.98 (0.12)	100 (0)	57.36 (0.22)
🔴	app/client/src/components/ads/Tabs.tsx	22.92 (-4.58)	18.18 (-21.82)	0 (0)	22.92 (-4.58)
🟢	app/client/src/components/editorComponents/ApiResponseView.tsx	54.17 (1.31)	37.5 (2.02)	0 (0)	55.71 (1.3)
🔴	app/client/src/components/editorComponents/CloseEditor.tsx	50 (-6.52)	50 (-50)	0 (0)	50 (-6.52)
✨ 🆕	app/client/src/components/editorComponents/ActionCreator/Fields.tsx	29	26.09	7.69	28.14
✨ 🆕	app/client/src/components/editorComponents/ActionCreator/index.tsx	48.78	11.43	56.52	47.93
🟢	app/client/src/components/editorComponents/CodeEditor/BindingPrompt.tsx	100 (0)	75 (8.33)	100 (0)	100 (0)
✨ 🆕	app/client/src/components/editorComponents/CodeEditor/commandsHelper.ts	41.07	41.67	22.22	43.14
✨ 🆕	app/client/src/components/editorComponents/CodeEditor/generateQuickCommands.tsx	16.95	0	0	15.52
🟢	app/client/src/components/editorComponents/CodeEditor/hintHelpers.ts	90 (1.9)	91.67 (0)	55.56 (12.7)	89.36 (1.86)
🔴	app/client/src/components/editorComponents/CodeEditor/index.tsx	72.96 (-1.46)	55.04 (0.42)	52.78 (-6.04)	73.64 (-1.61)
🟢	app/client/src/components/editorComponents/CodeEditor/styledComponents.ts	93.06 (0.64)	55.56 (0)	100 (0)	95.71 (0.4)
🟢	app/client/src/components/editorComponents/Debugger/hooks.ts	33.33 (7.14)	0 (0)	7.14 (7.14)	32.88 (8.22)
🟢	app/client/src/components/editorComponents/GlobalSearch/SearchResults.tsx	27.36 (0)	25.35 (1.35)	0 (0)	28.16 (0)
🟢	app/client/src/components/editorComponents/form/fields/DropdownFieldWrapper.tsx	21.05 (4.38)	0 (0)	0 (0)	23.53 (4.78)
🟢	app/client/src/components/formControls/DynamicTextFieldControl.tsx	98.15 (0.04)	70.59 (0)	88.89 (0)	98.04 (0.04)
✨ 🆕	app/client/src/components/utils/CollapseComponent.tsx	40	20	0	46.15
🟢	app/client/src/constants/DefaultTheme.tsx	96.23 (3.85)	89.47 (0.58)	85.71 (14.28)	95.56 (4.55)
🔴	app/client/src/constants/messages.ts	70.79 (-1.13)	100 (0)	11.68 (-3.41)	76.35 (0.16)
🟢	app/client/src/constants/routes.ts	84.21 (1.28)	43.48 (0.8)	66.67 (1.96)	82.61 (1.48)
🔴	app/client/src/icons/MenuIcons.tsx	62.16 (-2.7)	100 (0)	17.65 (-5.88)	62.16 (-2.7)
🔴	app/client/src/pages/Editor/Popper.tsx	85 (-0.37)	72.22 (0.48)	88.89 (0)	85 (-0.37)
🟢	app/client/src/pages/Editor/PropertyPaneTitle.tsx	83.02 (0.33)	38.64 (0)	82.35 (1.1)	81.63 (0.38)
🟢	app/client/src/pages/Editor/routes.tsx	39.71 (0.9)	22.22 (0)	6.67 (0)	44.07 (0.97)
🟢	app/client/src/pages/Editor/utils.ts	42.39 (0.63)	12.9 (0)	25 (0)	44.19 (0.66)
🟢	app/client/src/pages/Editor/APIEditor/CurlImportForm.tsx	75 (6.43)	85.71 (0)	33.33 (13.33)	79.31 (5.12)
🟢	app/client/src/pages/Editor/APIEditor/Form.tsx	38.04 (0.24)	47.92 (0)	0 (0)	40.26 (0.26)
🟢	app/client/src/pages/Editor/APIEditor/ProviderTemplates.tsx	35.29 (0)	40.82 (3.08)	4.76 (0)	37.63 (0)
🔴	app/client/src/pages/Editor/APIEditor/index.tsx	30.77 (-0.36)	3.64 (0.13)	5 (0)	33.33 (-0.35)
🔴	app/client/src/pages/Editor/DataSourceEditor/BackButton.tsx	58.82 (-26.89)	100 (0)	0 (0)	58.82 (-26.89)
🟢	app/client/src/pages/Editor/DataSourceEditor/DBForm.tsx	47.95 (1.9)	29.63 (5.63)	7.69 (0.55)	47.89 (1.94)
🟢	app/client/src/pages/Editor/DataSourceEditor/JSONtoForm.tsx	16.31 (0.6)	20.29 (0)	4.55 (0)	17.46 (0.66)
🟢	app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx	26.04 (0.13)	19.64 (0)	3.03 (0.09)	29.34 (0.17)
🔴	app/client/src/pages/Editor/DataSourceEditor/index.tsx	27.27 (-1.15)	0 (0)	11.11 (-0.65)	28.41 (-0.66)
🟢	app/client/src/pages/Editor/Explorer/Actions/ActionEntityContextMenu.tsx	38.89 (3.41)	0 (0)	0 (0)	40 (3.33)
🔴	app/client/src/pages/Editor/Explorer/Actions/helpers.tsx	46.77 (-8.61)	35.85 (-2.93)	20 (-11.82)	49.06 (-7.08)
🔴	app/client/src/pages/Editor/Explorer/Datasources/DatasourceEntity.tsx	35.56 (-0.8)	0 (0)	0 (0)	35.56 (-0.8)
🟢	app/client/src/pages/Editor/Explorer/PluginGroup/PluginGroup.tsx	88.46 (0.46)	61.4 (0)	60 (0)	88 (0.5)
✨ 🆕	app/client/src/pages/Editor/IntegrationEditor/ActiveDataSources.tsx	46.81	47.06	9.09	55.26
✨ 🆕	app/client/src/pages/Editor/IntegrationEditor/AddDatasourceSecurely.tsx	90.91	100	0	90.91
✨ 🆕	app/client/src/pages/Editor/IntegrationEditor/DatasourceCard.tsx	53.06	50	0	54.17
✨ 🆕	app/client/src/pages/Editor/IntegrationEditor/DatasourceHome.tsx	55.26	53.33	11.11	60.61
✨ 🆕	app/client/src/pages/Editor/IntegrationEditor/IntegrationsHomeScreen.tsx	28.36	12.82	5.26	30.83
✨ 🆕	app/client/src/pages/Editor/IntegrationEditor/MockDataSources.tsx	55.56	87.5	0	55.56
✨ 🆕	app/client/src/pages/Editor/IntegrationEditor/NewApi.tsx	62.5	66.67	0	64.52
✨ 🆕	app/client/src/pages/Editor/IntegrationEditor/NewQuery.tsx	54.55	100	16.67	68.75
✨ 🆕	app/client/src/pages/Editor/IntegrationEditor/index.tsx	71.43	100	0	71.43
✨ 🆕	app/client/src/pages/Editor/PropertyPane/ConnectDataCTA.tsx	88.24	100	85.71	87.88
✨ 🆕	app/client/src/pages/Editor/PropertyPane/PropertyPaneConnections.tsx	56.94	38.24	32.14	57.14
🟢	app/client/src/pages/Editor/PropertyPane/index.tsx	83.18 (0.18)	72.82 (1.24)	68 (0)	84.85 (0.98)
🔴	app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx	45.58 (-2.93)	45.71 (-2.77)	0 (0)	47.86 (-2.92)
🔴	app/client/src/pages/Editor/QueryEditor/index.tsx	32.18 (-0.77)	12.12 (0.69)	7.69 (0)	34.18 (-0.82)
🔴	app/client/src/pages/Editor/SaaSEditor/DatasourceForm.tsx	34.02 (-1.4)	16 (-3.05)	6.25 (0)	35.96 (-1.54)
🔴	app/client/src/pages/common/CustomizedDropdown/dropdownHelpers.tsx	34.48 (-6.9)	0 (-6.67)	0 (-33.33)	32.14 (-7.15)
🔴	app/client/src/reducers/entityReducers/datasourceReducer.ts	9.09 (-1.55)	0 (0)	0 (0)	9.62 (-1.49)
🔴	app/client/src/sagas/ActionSagas.ts	11.6 (-0.41)	1 (-0.06)	4.17 (-0.38)	14.07 (-0.52)
🟢	app/client/src/sagas/ApiPaneSagas.ts	15.49 (0.21)	1.87 (0)	7.14 (-0.27)	17.39 (0.19)
🔴	app/client/src/sagas/DatasourcesSagas.ts	13.19 (-0.77)	1.96 (-0.15)	8.7 (-0.82)	15.61 (-0.83)
🔴	app/client/src/sagas/OnboardingSagas.ts	16.71 (-1.35)	1.46 (-2.19)	10.2 (-2.04)	16.83 (-1.58)
🟢	app/client/src/sagas/selectors.tsx	72.04 (1.25)	54.55 (0)	48.15 (4.15)	66.2 (2.02)
🟢	app/client/src/selectors/entitiesSelector.ts	47.77 (2.52)	5.56 (0)	19.28 (3.43)	45.45 (3.12)
🔴	app/client/src/utils/AppsmithUtils.tsx	54.19 (-2.23)	26.74 (-2.33)	37.84 (-5.4)	49.68 (-2.58)
❌	~~app/client/src/actions/collectionAction.ts~~	75	~~100~~	0	~~66.67~~
❌	~~app/client/src/actions/utilActions.ts~~	~~71.43~~	~~100~~	0	~~100~~
❌	~~app/client/src/components/editorComponents/ActionCreator.tsx~~	~~34.67~~	~~23.22~~	~~22.22~~	~~33.68~~
❌	~~app/client/src/components/editorComponents/LightningMenu/LightningMenuTrigger.tsx~~	~~87.88~~	~~54.55~~	90	~~86.21~~
❌	~~app/client/src/components/editorComponents/LightningMenu/helpers.tsx~~	~~58.82~~	25	20	~~53.33~~
❌	~~app/client/src/components/editorComponents/LightningMenu/hooks.ts~~	~~73.33~~	25	~~42.86~~	~~70.37~~
❌	~~app/client/src/components/editorComponents/LightningMenu/index.tsx~~	~~91.3~~	0	~~66.67~~	90
❌	~~app/client/src/pages/Editor/APIEditor/ApiHomeScreen.tsx~~	~~37.04~~	~~24.32~~	~~3.57~~	~~37.4~~
❌	~~app/client/src/pages/Editor/DataSourceEditor/DatasourceHome.tsx~~	~~56.52~~	~~52.63~~	10	~~58.14~~
❌	~~app/client/src/pages/Editor/QueryEditor/AddDatasourceSecurely.tsx~~	~~91.67~~	~~100~~	0	~~91.67~~
❌	~~app/client/src/pages/Editor/QueryEditor/DatasourceCard.tsx~~	~~58.97~~	~~52.94~~	0	~~58.97~~
❌	~~app/client/src/pages/Editor/QueryEditor/QueryHomeScreen.tsx~~	~~41.07~~	~~42.11~~	~~8.33~~	~~44.9~~
❌	~~app/client/src/pages/common/CustomizedDropdown/StyledComponents.tsx~~	32	~~46.15~~	~~5.56~~	32
❌	~~app/client/src/pages/common/CustomizedDropdown/index.tsx~~	~~78.79~~	~~42.86~~	~~83.33~~	~~77.42~~

2. Added connect buttons to em

…eature/new-nav-complete

pranavkanade · 2021-07-06T10:54:14Z

/ok-to-test sha=3e5f12c

* will show scrollbar only on hover * made mock data cards clickable * fixed the grid view * fixed the cursor position when clicking on / btn * updated the hint for `/` command * binding prompt will close on focus change * hiding / command for api body * hiding / command for query pane

pranavkanade · 2021-07-06T11:38:21Z

/ok-to-test sha=adbcbdf

…menu button

…eature/new-nav-complete

pranavkanade · 2021-07-06T16:46:20Z

/ok-to-test sha=3daecd6

pranavkanade · 2021-07-06T19:01:20Z

/ok-to-test sha=8a36053

pranavkanade added 30 commits May 26, 2021 15:29

temp commit

26e5a24

using onsubmit to continue using action on form

effbabf

added recaptcha site key to env example file

c54a2d3

moved the recaptcha lib loading logic to signup page

f04cb46

removed unnecessary edit

e134810

handle the case where the recaptcha token is not provided as env var

bdbd25f

added proper env var config for client

6698db4

recaptcha config for ansible

ce149c9

recaptcha config for heroku

ac16066

recaptcha config for k8s

bc00ef8

updated app.json

55c4be7

Merge branch 'release' into feature/recaptcha-for-signup

385395f

fixed the typos

a621560

added more description for env vars

f73f2a9

removed api key

59196fc

Merge branch 'release' into feature/recaptcha-for-signup

0dc0e28

minor typo fix

7906749

added new integration button

741f8eb

updated the add int default link

069b869

added active and create new tabs

b639034

added the empty components to tabs. will control the section manually.

2d3786e

added proper grid for integrations page

5e7273d

added vertical tabs

a3f26fe

Added secondary tabs to integrations page

7d74373

added separate page for new apis

de3bd9a

classname changes

f1642f2

added new components for active queries, new queries etc.

c78a559

added a separate component for data source list

aaefc0d

adding screen component conditionally, to be showing upon user's choice

2579af0

1. Added grid styling to datasource home

f8dcc82

2. Added connect buttons to em

Merge remote-tracking branch 'origin/feature/new-nav-complete' into f…

3e5f12c

…eature/new-nav-complete

pranavkanade requested a review from rishabhsaxena July 6, 2021 12:23

rishabhsaxena previously approved these changes Jul 6, 2021

View reviewed changes

Added 2 new icons

c70ef94

pranavkanade dismissed rishabhsaxena’s stale review via c70ef94 July 6, 2021 12:44

rishabhrathod01 self-requested a review July 6, 2021 13:00

rishabhrathod01 previously approved these changes Jul 6, 2021

View reviewed changes

Fix cursor position on selecting a binding and clicking on the slash …

264d8e8

…menu button

rishabhsaxena dismissed rishabhrathod01’s stale review via 264d8e8 July 6, 2021 14:53

pranavkanade added 2 commits July 6, 2021 22:10

trying out fix to copyWidget cy command

b7687f3

Merge remote-tracking branch 'origin/feature/new-nav-complete' into f…

3daecd6

…eature/new-nav-complete

pranavkanade requested a review from arslanhaiderbuttar July 6, 2021 16:40

pranavkanade requested a review from rishabhsaxena July 6, 2021 16:47

arslanhaiderbuttar previously approved these changes Jul 6, 2021

View reviewed changes

removing zero width space characters from the property pane text

8a36053

pranavkanade dismissed arslanhaiderbuttar’s stale review via 8a36053 July 6, 2021 19:00

pranavkanade requested a review from arslanhaiderbuttar July 6, 2021 19:10

rishabhrathod01 approved these changes Jul 6, 2021

View reviewed changes

pranavkanade merged commit f414285 into release Jul 7, 2021

pranavkanade deleted the feature/new-nav-complete branch July 7, 2021 03:46

This was referenced Jul 7, 2021

[Bug] Binding instruction shows up when / commands are open #5565

Closed

Feature/slash commands #5523

Closed

[Test]deploy preview new nav #5536

Closed

This was referenced Jul 19, 2021

[Feature] Button add a widget, API, or DB query in empty state #2507

Closed

[Feature] Allow a way for users to quickly reach back to last edited canvas from Api pane / query pane / datasource pane. #3114

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Feature] Unified New Nav#5558

[Feature] Unified New Nav#5558
pranavkanade merged 198 commits into
releasefrom
feature/new-nav-complete

pranavkanade commented Jul 2, 2021 •

edited by github-actions Bot

Loading

Uh oh!

pranavkanade commented Jul 6, 2021

Uh oh!

pranavkanade commented Jul 6, 2021

Uh oh!

pranavkanade commented Jul 6, 2021

Uh oh!

pranavkanade commented Jul 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

pranavkanade commented Jul 2, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Test coverage results 🧪

Uh oh!

pranavkanade commented Jul 6, 2021

Uh oh!

pranavkanade commented Jul 6, 2021

Uh oh!

pranavkanade commented Jul 6, 2021

Uh oh!

pranavkanade commented Jul 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pranavkanade commented Jul 2, 2021 •

edited by github-actions Bot

Loading