fix: Input widget as number type 0 as default value#7251
Merged
Conversation
jsartisan
previously approved these changes
Sep 10, 2021
somangshu
previously approved these changes
Sep 10, 2021
ashit-rath
dismissed stale reviews from somangshu and jsartisan
via
September 14, 2021 14:02
06ccafe
Contributor
Author
|
@somangshu Can you verify this? |
jsartisan
previously approved these changes
Sep 15, 2021
jsartisan
previously approved these changes
Sep 15, 2021
|
@ashit-rath After I remove the default text as “0” still the value is coming on input widget. |
vicky-primathon
approved these changes
Sep 15, 2021
vicky-primathon
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me
Contributor
Author
|
@vivekverma2312 This issue has been addressed, can you do a round of testing and approve?
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7246
Type of change
How Has This Been Tested?
Manual
Checklist:
Test coverage results 🧪
🟢 Total coverage has increased