Skip to content

fix: Input widget as number type 0 as default value#7251

Merged
ashit-rath merged 6 commits into
releasefrom
fix/7246-input-widget-default-value-0
Sep 16, 2021
Merged

fix: Input widget as number type 0 as default value#7251
ashit-rath merged 6 commits into
releasefrom
fix/7246-input-widget-default-value-0

Conversation

@ashit-rath

@ashit-rath ashit-rath commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

Description

Fixes #7246

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/7246-input-widget-default-value-0 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.87 (0.01) 36.69 (0.06) 34.26 (0.03) 55.41 (0.02)
🟢 app/client/src/constants/messages.ts 75.04 (0.13) 100 (0) 25.59 (0.4) 81.23 (-0.06)
🟢 app/client/src/widgets/InputWidget/widget/index.tsx 61.76 (8.22) 41.43 (18.57) 68.18 (4.54) 63.92 (8.6)

@ashit-rath
ashit-rath requested a review from jsartisan September 8, 2021 11:32
@github-actions github-actions Bot added the Bug Something isn't working label Sep 8, 2021
jsartisan
jsartisan previously approved these changes Sep 10, 2021
somangshu
somangshu previously approved these changes Sep 10, 2021
@ashit-rath
ashit-rath dismissed stale reviews from somangshu and jsartisan via 06ccafe September 14, 2021 14:02
@ashit-rath

Copy link
Copy Markdown
Contributor Author

@somangshu Can you verify this?

jsartisan
jsartisan previously approved these changes Sep 15, 2021
jsartisan
jsartisan previously approved these changes Sep 15, 2021
@vivekverma2312

vivekverma2312 commented Sep 15, 2021

Copy link
Copy Markdown

@ashit-rath After I remove the default text as “0” still the value is coming on input widget.
LOOM DEMO

@vicky-primathon vicky-primathon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ashit-rath

ashit-rath commented Sep 15, 2021

Copy link
Copy Markdown
Contributor Author

@vivekverma2312 This issue has been addressed, can you do a round of testing and approve?

@ashit-rath After I remove the default text as “0” still the value is coming on input widget.
LOOM DEMO

@ashit-rath
ashit-rath merged commit 0354fda into release Sep 16, 2021
@ashit-rath
ashit-rath deleted the fix/7246-input-widget-default-value-0 branch September 16, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Input Widget does not show default value if it is 0 for number type

5 participants