Skip to content

fix: Use undefined as default value for input type number and integer#7398

Closed
vicky-primathon wants to merge 2 commits into
releasefrom
fix/input-widget-default-value
Closed

fix: Use undefined as default value for input type number and integer#7398
vicky-primathon wants to merge 2 commits into
releasefrom
fix/input-widget-default-value

Conversation

@vicky-primathon

@vicky-primathon vicky-primathon commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

Description

Use undefined as default value for input type number and integer

Fixes # (issue)

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/input-widget-default-value 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.89 (0.02) 36.92 (0.05) 34.24 (0.01) 55.41 (0.02)
🟢 app/client/src/widgets/InputWidget/widget/index.tsx 60.4 (6.86) 38.89 (16.03) 68.18 (4.54) 62.5 (7.18)

@vicky-primathon
vicky-primathon marked this pull request as draft September 14, 2021 05:47
@vicky-primathon vicky-primathon changed the title WIP: Use undefined as default value for input type number and integer fix: Use undefined as default value for input type number and integer Sep 14, 2021
@github-actions github-actions Bot added the Bug Something isn't working label Sep 14, 2021
@ashit-rath

Copy link
Copy Markdown
Contributor

Closing this in favor of #7251

@ashit-rath ashit-rath closed this Sep 16, 2021
@mohanarpit
mohanarpit deleted the fix/input-widget-default-value branch October 8, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants