fix: depend on faststream's git main for the real tombstone fix#16
Merged
Conversation
ag2ai/faststream#2932 (the actual upstream fix for publish(None, ...) not sending a real Kafka null value) is merged to main but not yet in a PyPI release. Point the kafka extra at git+https://github.com/ag2ai/ faststream.git@main instead of waiting, and drop the runtime monkeypatch in depends.py entirely - the real fix now lives upstream, so there's nothing left to patch. Bumps to 0.4.49. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Tracking main means the resolved commit silently drifts on every poetry lock, and this is production infra - reproducible builds matter more than always-latest. Pin to 9d54a6d8, the commit that includes ag2ai/faststream#2932, and re-lock explicitly when it's time to move (e.g. once #2933 merges too). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.4.48 worked around the tombstone bug with a runtime monkeypatch (patching AsyncConfluentFastProducerImpl.publish() in place) because the actual fix - ag2ai/faststream#2932 - wasn't released yet. It's merged to main now, just not in a PyPI release.
Points the kafka extra at faststream's git main directly instead of waiting for a release, and deletes the monkeypatch entirely - nothing left to patch, the real fix is what's installed.
Bumps to 0.4.49.
Note: there's a second, independent fix still pending upstream (ag2ai/faststream#2933, consumer-side - lets
Optional[Model] = Noneresolve correctly for a real tombstone instead of crash-looping on required fields). Once that merges too, this can bump again with no further changes needed here.Test plan
tests/kafka/suite passes (18/18) against the git-sourced faststream, no monkeypatch.cmd.body is Nonepresent in the installedproducer.py), not a stale cached version.