fix: revert git dependency, restore monkeypatch - PyPI rejects direct refs#18
Merged
Conversation
… refs 0.4.49's publish failed: PyPI's upload validation hard-rejects any package declaring a direct git/URL dependency (HTTP 400 "Can't have direct dependency"). That's not a config issue - it's a policy PyPI enforces on every upload, so pointing the kafka extra at faststream's git main broke the publish step for good, not just this one release. Revert to a plain "faststream[otel,confluent]" PyPI dependency and restore the AsyncConfluentFastProducerImpl.publish() monkeypatch from 0.4.48. ag2ai/faststream#2932 is merged upstream but has no PyPI release yet, so the shim stays until one exists. Bumps to 0.4.50 (0.4.49 never actually published - the tarball was rejected before completing). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16 broke the publish pipeline. PyPI's upload validation hard-rejects any package that declares a direct git/URL dependency:
That's enforced on every upload, not something we can configure around - so 0.4.49 never actually published (confirmed on PyPI, nothing partial), and every future merge to main would also fail at the same step until this is fixed.
Reverts to a plain
faststream[otel,confluent]PyPI dependency and restores theAsyncConfluentFastProducerImpl.publish()monkeypatch from 0.4.48.ag2ai/faststream#2932is merged upstream but has no PyPI release yet, so the shim needs to stay until one exists - there's no way to get the real fix installed from PyPI alone right now.Bumps to 0.4.50.
Test plan
tests/kafka/suite passes (18/18) with the restored shim.faststream's lock entry is a genuine PyPI wheel/sdist again, no[package.source]git block.