Skip to content

test: v3 ACP-allowed proof - #147

Merged
aram-devdocs merged 1 commit into
mainfrom
test/issue-146-v3-acp-allowed-proof
Apr 29, 2026
Merged

test: v3 ACP-allowed proof#147
aram-devdocs merged 1 commit into
mainfrom
test/issue-146-v3-acp-allowed-proof

Conversation

@aram-devdocs

Copy link
Copy Markdown
Owner

Fixes #146

Summary

One-line CHANGELOG.md addition under Unreleased / Added — proof that the v3 visible-flow lands diffs end-to-end with acpx.permissionMode=approve-all + Codex sandbox=danger-full-access.

Test plan

  • CHANGELOG.md has new bullet under ## [Unreleased] / ### Added
  • No other files changed

@aram-devdocs
aram-devdocs merged commit 31ca258 into main Apr 29, 2026
5 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

I now have everything I need. Let me write the review.


PR #141chore: remove README metadata comment

Branch: test/issue-140-readme-v3-commentmain
Fixes: #140
Files touched: README.md only (no Rust source)


File buckets

Bucket Files
docs README.md

Rust invariant checks

All pass vacuously — there are no Rust source changes in this PR.

  • Determinism: N/A
  • Workspace layering: N/A
  • unsafe: N/A
  • unwrap/expect in library crates: N/A
  • println!/eprintln! outside plumb-cli: N/A
  • todo!/unimplemented!/dbg!: N/A
  • HashMap/HashSet in output paths: N/A
  • cargo-deny / new deps: N/A

CI status

All 14 checks pass on the head commit (ca3d9c9b): preflight, test (3 platforms), determinism, size guard, MSRV, cargo-deny, Conventional Commits, docs build, coverage, GitGuardian, Claude review.


Findings

[BLOCKER] Net-zero diff closes issue #140 without satisfying it

The PR contains two commits that self-cancel:

  • e3265800 (test: acknowledge v3 multi-agent setup in README) — adds <!-- aram-ai-global v3 multi-agent stack now drives PRs end-to-end. --> at README.md:1.
  • ca3d9c9b (docs: remove hidden README metadata comment) — removes the same line.

gh api repos/aram-devdocs/plumb/pulls/141/files returns []. Merging this PR leaves README.md byte-identical to main. Issue #140 explicitly requests that the comment persist ("squash-merge once green"). This PR closes the issue without implementing what it asked.

[WARNING] PR body misrepresents the change

The summary section reads: "Added the requested top-of-file README comment acknowledging the aram-ai-global v3 multi-agent PR flow." This accurately describes commit 1 but ignores commit 2, which undoes it. The net effect — nothing — is not described anywhere in the body.

[WARNING] Wrong Conventional Commits type for commit 1

test: acknowledge v3 multi-agent setup in README uses the test: scope for a README.md edit. Per the Conventional Commits spec and this project's usage, test: is reserved for test-code changes. The correct type here is docs:. The CC hook accepted it (any scope with a colon passes the linter), but it is semantically wrong and will confuse git log readers.


Punch list

# Location Severity Note
1 README.md (net diff) BLOCKER PR merges as a no-op; issue #140 asks for the comment to persist — either revert commit 2 and keep the comment, or update issue #140 to reflect a changed intent before merging
2 PR body, "Summary" section WARNING Inaccurate: describes only commit 1; revise to describe the actual net effect
3 Commit e3265800 message WARNING Replace test: with docs:

Verdict: REQUEST_CHANGES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: v3 acp-allowed proof

1 participant