This repository was archived by the owner on Jun 13, 2023. It is now read-only.
[ruby] Upgrade rubocop-rspec to version 1.34.0#78
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop-rspec (~> 1.33.0 → ~> 1.34.0) · Repo · Changelog
Release Notes
1.34.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 51 commits:
Merge pull request #787 from rubocop-hq/releaseBump version to 1.34.0Merge pull request #784 from pirj/fix-pending-specAdd support for metadataFix namespace detectionRemove redundant hook scopeRemove redundant conversionTake innermost class for described_classSwitch to newer expect_correction syntaxRemove unused module inclusionMake example wording consistentSimplify DescribedClass cop default config testsMerge pull request #781 from pirj/fix-obscure-syntax-in-readmeMerge pull request #783 from hanapei00/topic_update_readme_usage_command_lineMerge pull request #782 from pirj/allow-rspec-as-top-level-constantdescription position change and write as yamlupdate document how to use multiple extensions.Fix typos in the changelogImprove detection by allowing the use of ::RSpecFix obscure syntax in the exampleMerge pull request #780 from nc-holodakg/improve-should-wording-detectionImprove detection for ExampleWording copMerge pull request #778 from foton/LetSetup_message_impovedChanged message of RSpec/LetSetup cop to be more descriptiveMerge pull request #779 from pirj/improve-examples-for-leaky-constant-declaration-copImprove examples for LeakyConstantDeclaration copMerge pull request #770 from pirj/improve-subject-stub-copImprove detection of unnamed subject stubbingAdd spy stubbing in SubjectStubAdd Changelog entry for multiple changesRemove special case `all` matcher from SubjectStubAdd more reasoning references to SubjectStubImprove offence message for SubjectStubAdd support for chain and multiple stub detectionAdd detection of negated runnersImprove stub detectionUse consistent wording in docstringsMerge pull request #768 from pirj/improve-aggregate_failures-detection-in-multiple-expectations-copMerge pull request #774 from pirj/use-rubocop-internal-affairsImprove MultipleExpectations metadata detectionDisable InternalAffairs/NodeDestructuring copUse RuboCop internal affairs departmentMerge pull request #765 from pirj/add-leaky-constant-declaration-copDisable LeakyConstantDeclarationAdd RSpec/LeakyConstantDeclaration copMerge pull request #762 from pirj/fix-doc-issue-for-context-wordingFix doc issue for ContextWording copMerge pull request #767 from rubocop-hq/fix-changelogFix changelogMerge pull request #760 from pirj/drop-aggregate-failures-by-default-option-for-multiple-expectationsRemove AggregateFailuresByDefault config option for MultipleExpectationsDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands