fix(applicationset): correct SCM provider generator filter evaluation

[nitishfy]

Closes #23881
Closes #22503

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Title of the PR
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[codecov]

Bundle Report

Bundle size has no change ✅

[codecov]

Codecov Report

❌ Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@6b852eb). Learn more about missing BASE report.
⚠️ Report is 70 commits behind head on master.

Files with missing lines	Patch %	Lines
applicationset/services/scm_provider/utils.go	89.74%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #28811   +/-   ##
=========================================
  Coverage          ?   65.30%           
=========================================
  Files             ?      426           
  Lines             ?    59975           
  Branches          ?        0           
=========================================
  Hits              ?    39168           
  Misses            ?    17213           
  Partials          ?     3594           

Flag	Coverage Δ
e2e	26.81% <51.28%> (?)
unit-tests	60.70% <89.74%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[ppapapetrou76]

LGTM

[ppapapetrou76]

the changes in this file look like they are not relevant

[nitishfy]

yeah i think maybe that's the reason why codegen is failing, let me try that again