orangepizero3w: Add community support for Orange Pi Zero 3W (Allwinner A733)

[shkolnik]

Description

Community (.csc) board support for the Orange Pi Zero 3W — the WiFi-only little sibling
of the Orange Pi 4 Pro, same Allwinner A733 (sun60iw2) SoC. I run one as a headless Trixie
server and have been dogfooding it; it boots and runs nicely. Open to feedback.

Since this is the second Orange Pi A733 board, I factored the shared bits of the two board files
into a small vendor include, so they read as a real two-board family rather than copy-paste. The
4 Pro change is a behavior-preserving refactor — the only existing file this PR touches.

What's added

• config/boards/orangepizero3w.csc — board config (DTB + board-specific DRAM blob).
• config/sources/vendors/xunlong/sun60iw2-a733-common.inc — new shared A733 include.
• patch/kernel/archive/sun60iw2-opi-vendor/0006-orangepizero3w-set-model-and-compatible.patch —
  the vendor left the 4 Pro's identity in the copied DTS; this sets a correct model and a
  board-specific compatible (xunlong,orangepi-zero3w, falling back to arm,sun60iw2p1).
• config/boards/orangepi4pro.csc — refactored to source the shared include.

Differences from the 4 Pro: no Ethernet (WiFi only), no SPI-NOR / M.2 (microSD boot), its own
DRAM blob + DTB. WiFi/BT is the same AICSemi AIC8800D80 over SDIO, so it reuses the family's in-tree
driver — no new firmware. Bluetooth bring-up is a gap shared with the 4 Pro; I'll handle it
family-wide in a follow-up rather than widen scope here. GPU/NPU/VPU stay opt-in (no proprietary
blobs baked into the image), same policy as the 4 Pro.

Dependencies: boot blobs pinned to
orangepi-xunlong/orangepi-build @ 7f776a20
(board-specific boot0_sdcard, shared sys_config). Kernel and U-Boot are unchanged from the
existing sun60iw2 family.

GitHub issue reference: N/A — new community board
Jira reference number: N/A

How Has This Been Tested?

Built a Trixie CLI image, flashed, and booted on real hardware (Orange Pi Zero 3W):

• microSD boot to headless login; joins WiFi on first boot (WiFi 6 / 5 GHz, DHCP).
• Kernel 6.6.98-vendor-sun60iw2; 8 cores (2×A76 + 6×A55); full RAM.
• /proc/device-tree/model = "Orange Pi Zero 3W", compatible = xunlong,orangepi-zero3w.
• GPU/NPU nodes present (/dev/dri/card0, /dev/vipcore); acceleration is opt-in.
• No Ethernet interface (by design).

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

Thanks!
-James

Summary by CodeRabbit

• New Features
  • Added support for the Orange Pi Zero 3W, including board detection and build targets.
  • Added shared boot-image write support for the sun60iw2 family.
• Bug Fixes
  • Fixed device identity for the Orange Pi Zero 3W so the reported model/compatible values are correct.
  • Improved bootloader image writing reliability (including error handling) for Cubie A7Z.
  • Updated Orange Pi 4 Pro system configuration handling and cache invalidation when boot components change.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• Needs review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5b08423b-4d44-4198-bb29-9c2fa72824e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds a shared sun60iw2 boot writer, updates board configs to use the new sys_config input and writer behavior, introduces an Orange Pi Zero 3W board definition, and patches its device-tree model and compatible strings.

Changes

Sun60iw2 shared config and board definitions

Layer / File(s)	Summary
Shared sun60iw2 boot writer config/sources/families/sun60iw2.conf	Makes OVERLAY_PREFIX unconditional and adds write_uboot_platform() to validate boot blobs, write them at fixed offsets, and sync the target device.
Board config updates config/boards/cubie-a7z.csc, config/boards/orangepi4pro.csc	Updates Orange Pi 4 Pro blob inputs and hashing, removes its local writer, and hardens the Cubie A7Z writer with file checks and write-failure handling.
New Orange Pi Zero 3W board config/boards/orangepizero3w.csc	Adds the Orange Pi Zero 3W board metadata, target settings, boot blob paths, and U-Boot hash inputs.
Zero 3W device-tree identity patch/kernel/archive/sun60iw2-opi-vendor/0006-orangepizero3w-set-model-and-compatible.patch	Sets the Zero 3W DTS model string and updates its compatible list.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• armbian/build#10036: Also changes write_uboot_platform() behavior for sun60iw2 board boot blob writing.
• armbian/build#9967: Related to shared boot-offset and boot writer handling for the same family.

Suggested reviewers: igorpecovnik, EvilOlaf

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding community support for the Orange Pi Zero 3W on Allwinner A733.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

config/sources/vendors/xunlong/sun60iw2-a733-common.inc (1)

10-14: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Undocumented pre-condition on SUNXI_BOOT0_SDCARD_FEX/SUNXI_BOOT0_SPINOR_FEX.

UBOOT_HASH_EXTRA depends on SUNXI_BOOT0_SDCARD_FEX and SUNXI_BOOT0_SPINOR_FEX, but these are only defined by the board that sources this include (correctly ordered today in orangepi4pro.csc). Nothing here enforces or documents that requirement, so a future board sourcing this include out of order would silently hash empty/partial input instead of failing.

♻️ Proposed defensive guard

 # Invalidate U-Boot cache if any of the blobs change
+: "${SUNXI_BOOT0_SDCARD_FEX:?SUNXI_BOOT0_SDCARD_FEX must be set before sourcing sun60iw2-a733-common.inc}"
+: "${SUNXI_BOOT0_SPINOR_FEX:?SUNXI_BOOT0_SPINOR_FEX must be set before sourcing sun60iw2-a733-common.inc}"
 UBOOT_HASH_EXTRA="$(cat "${SUNXI_BOOT0_SDCARD_FEX}" "${SUNXI_BOOT0_SPINOR_FEX}" "${SUNXI_SYS_CONFIG_FEX}" | sha256sum | cut -d' ' -f1)"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@config/sources/vendors/xunlong/sun60iw2-a733-common.inc` around lines 10 -
14, The UBOOT_HASH_EXTRA calculation in the sun60iw2 common include assumes
SUNXI_BOOT0_SDCARD_FEX and SUNXI_BOOT0_SPINOR_FEX are already defined, but
nothing in this include enforces that precondition. Add a defensive guard near
the UBOOT_HASH_EXTRA setup in the shared include to verify those variables are
set before hashing, and fail fast with a clear error if they are missing so
boards like orangepi4pro.csc cannot source this file in the wrong order.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/boards/orangepi4pro.csc`:
- Around line 1-9: The board-config validator only reads top-level KEY=VALUE
assignments in the .csc, so BOARD_VENDOR is currently invisible because it lives
only in the sourced common include. Add BOARD_VENDOR back as a direct top-level
assignment in orangepi4pro.csc, and do the same for BOARDFAMILY if it is also
only inherited from sun60iw2-a733-common.inc, while keeping the source include
unchanged.

In `@config/boards/orangepizero3w.csc`:
- Line 9: The board metadata imported through the vendor include is not visible
to board validation, so keep the validator-required fields local in
orangepizero3w.csc instead of relying on the shared sun60iw2-a733-common.inc
include. Update the board file so validation can see BOARDFAMILY, KERNEL_TARGET,
and any other required metadata directly, while preserving the shared include
only for non-validation-dependent settings. Refer to the board config source
statement in the board file and the validator-sensitive fields that currently
come from the common include.

---

Nitpick comments:
In `@config/sources/vendors/xunlong/sun60iw2-a733-common.inc`:
- Around line 10-14: The UBOOT_HASH_EXTRA calculation in the sun60iw2 common
include assumes SUNXI_BOOT0_SDCARD_FEX and SUNXI_BOOT0_SPINOR_FEX are already
defined, but nothing in this include enforces that precondition. Add a defensive
guard near the UBOOT_HASH_EXTRA setup in the shared include to verify those
variables are set before hashing, and fail fast with a clear error if they are
missing so boards like orangepi4pro.csc cannot source this file in the wrong
order.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f6a8e045-c35b-4ad1-a695-df3c803cee98

📥 Commits

Reviewing files that changed from the base of the PR and between 172b1a9 and dce7dbd.

📒 Files selected for processing (6)

• config/boards/orangepi4pro.csc
• config/boards/orangepizero3w.csc
• config/sources/vendors/xunlong/sun60iw2-a733-common.inc
• packages/blobs/sunxi/sun60iw2/boot0_sdcard_orangepizero3w.fex
• packages/blobs/sunxi/sun60iw2/sys_config_orangepi.fex
• patch/kernel/archive/sun60iw2-opi-vendor/0006-orangepizero3w-set-model-and-compatible.patch

[EvilOlaf]

While I appreciate the the effort of deduplication of code, I don't believe this is the way to go.

BOARD_VENDOR="xunlong"
BOARDFAMILY="sun60iw2"
BOARD_MAINTAINER="shkolnik"
INTRODUCED="2025"
KERNEL_TARGET="vendor"
KERNEL_TEST_TARGET="vendor"
IMAGE_PARTITION_TABLE="msdos"

All this shall stay in each individual board config. Everything else shared belongs into family config, meaning sun60iw2.conf

[EvilOlaf]

as per comment

[shkolnik]

@EvilOlaf makes sense! There isn't much content to justify a shared include anymore. I also refactored write_platform_uboot into the family file.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/boards/orangepi4pro.csc`:
- Around line 19-20: Update the stale board comment in orangepi4pro.csc so it no
longer claims there is a “common include” or that blob fetch is shared there;
the shared A733 include was removed. Keep the note about the 4 Pro having 16 MB
SPI-NOR and bootloader-to-MTD support, but revise the wording to reflect that SD
writer logic may be shared elsewhere while DRAM blob fetching is handled
per-board via fetch_custom_uboot, not by a default include.

In `@config/sources/families/sun60iw2.conf`:
- Around line 141-146: Add explicit failure handling in write_uboot_platform so
it fails fast instead of silently continuing on bad inputs or dd errors. Check
that boot0_sdcard.fex and boot_package.fex exist before writing, verify each dd
invocation succeeds, and call exit_with_error with a clear message if any step
fails. Keep the changes localized to write_uboot_platform and align its error
handling style with uboot_custom_postprocess.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ffec18d8-7842-4317-9c5d-51c660ed9da1

📥 Commits

Reviewing files that changed from the base of the PR and between dce7dbd and 2331c05.

📒 Files selected for processing (4)

• config/boards/cubie-a7z.csc
• config/boards/orangepi4pro.csc
• config/boards/orangepizero3w.csc
• config/sources/families/sun60iw2.conf

addressed

[igorpecovnik]

lgtm (squash merge)

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!