Skip to content

jethome: fix jethub-burn extension: add BETA=yes support#10152

Merged
adeepn merged 1 commit into
armbian:mainfrom
jethome-iot:bugfix/jethub-burn-uboot-deb-beta
Jul 9, 2026
Merged

jethome: fix jethub-burn extension: add BETA=yes support#10152
adeepn merged 1 commit into
armbian:mainfrom
jethome-iot:bugfix/jethub-burn-uboot-deb-beta

Conversation

@adeepn

@adeepn adeepn commented Jul 9, 2026

Copy link
Copy Markdown
Member

Description

Nightly image jobs for JetHub boards fail while converting the image to Amlogic burn format:

INFO: Converting image to Amlogic burn format [ jethub-burn :: jethubj80 ]
ERROR: u-boot deb not found for jethubj80
ERROR: Exiting with error 43
   post_build_image__900_jethub_burn() --> extensions/jethub-burn.sh:133

How Has This Been Tested?

  • BETA=yes build ok

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Summary by CodeRabbit

  • Bug Fixes
    • Improved package lookup for image creation so it now uses the preferred storage location when available, with a fallback to the build output directory.
    • This helps the burn-image process find the correct Debian package more reliably during builds.

…t/debs

post_build_image__900_jethub_burn looked for the u-boot .deb in
${SRC}/output/debs, but BETA builds (BETA=yes, used by the nightly) place
reversioned debs in output/debs-beta (DEB_STORAGE). The Amlogic burn
conversion therefore failed with "u-boot deb not found for <board>".
Use ${DEB_STORAGE} with a fallback to the previous path.
@github-actions github-actions Bot added size/small PR with less then 50 lines 08 Milestone: Third quarter release Needs review Seeking for review Framework Framework components labels Jul 9, 2026
@adeepn adeepn changed the title fix(jethub-burn): find u-boot deb in DEB_STORAGE, not hardcoded outpu… jethome: fix jethub-burn extension: add BETA=yes support Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 27d3bcca-2669-4196-bac3-67ac7d8599a7

📥 Commits

Reviewing files that changed from the base of the PR and between d8387c6 and 5debeb3.

📒 Files selected for processing (1)
  • extensions/jethub-burn.sh

📝 Walkthrough

Walkthrough

The debs_dir variable in post_build_image__900_jethub_burn within extensions/jethub-burn.sh now checks the DEB_STORAGE environment variable first, falling back to ${SRC}/output/debs if unset. Subsequent logic for deb discovery, extraction, and burn-image creation is unchanged.

Changes

Jethub Burn Deb Directory Resolution

Layer / File(s) Summary
Deb directory fallback logic
extensions/jethub-burn.sh
debs_dir now prefers DEB_STORAGE when set, falling back to ${SRC}/output/debs as before.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the change because the DEB_STORAGE lookup fix supports BETA=yes builds, even if it is more specific about the build mode than the code change itself.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adeepn adeepn requested review from igorpecovnik and rpardini July 9, 2026 09:47
@adeepn adeepn merged commit 167f18d into armbian:main Jul 9, 2026
13 checks passed
@adeepn adeepn deleted the bugfix/jethub-burn-uboot-deb-beta branch July 9, 2026 12:36
@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants