uefi-cloud: enable SQUASHFS so the live ISO boots - #10345
Merged
Conversation
The cloud UEFI kernels (x86 and arm64) had CONFIG_BLK_DEV_LOOP=y and CONFIG_OVERLAY_FS=m but no CONFIG_SQUASHFS at all, while every other branch (current/edge/legacy/bleedingedge) enables it. image-output-iso builds the live ISO on the cloud branch, so booting it fails once live-boot tries to mount the rootfs: Can not mount /dev/loop0 (/run/live/medium/live/filesystem.squashfs) on /run/live/rootfs/filesystem.squashfs The loop device is set up fine (BLK_DEV_LOOP=y), but the kernel has no squashfs driver to read the image -- it is not a compressor problem. Enable SQUASHFS built-in with the same compressor set as the sibling branches, including SQUASHFS_ZSTD to match image-output-iso's default -comp zstd. Signed-off-by: Igor Pecovnik <igor@armbian.com>
Contributor
📝 WalkthroughWalkthroughChangesSquashFS cloud kernel support
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ This PR has been reviewed and approved — all set for merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
Booting the live UEFI ISO (from
image-output-iso) built on the cloud branch fails in the initramfs:live-boot finds the medium and sets up the loop device, but the squashfs mount itself fails.
Root cause
The cloud UEFI kernel configs have
CONFIG_BLK_DEV_LOOP=yandCONFIG_OVERLAY_FS=mbut noCONFIG_SQUASHFSat all — so the kernel has no filesystem driver to readfilesystem.squashfs. Every other branch (current/edge/legacy/bleedingedge) enables squashfs, which is why only cloud-branch ISOs fail. This is not a compressor mismatch — the driver is entirely absent.image-output-isobuilds the live ISO on the cloud branch (it's the branch that shipsvmlinux-*), so this combination is exactly what breaks.Fix
Enable SQUASHFS built-in (
=y, so it's available regardless of initrd contents) in bothlinux-uefi-x86-cloudandlinux-uefi-arm64-cloud, with the same compressor set as the sibling branches — includingCONFIG_SQUASHFS_ZSTD=yto matchimage-output-iso's default-comp zstd.Test
uefi-x86 BRANCH=cloudwithimage-output-iso, boot the ISO as a virtual CD — live system reaches userspace (squashfs mounts).Summary by CodeRabbit