Skip to content

drivers_network.sh remove version guards, rtl8723ds update hash & bind to family - #10353

Merged
EvilOlaf merged 2 commits into
armbian:mainfrom
EvilOlaf:rtl8723ds-7.2
Aug 10, 2026
Merged

drivers_network.sh remove version guards, rtl8723ds update hash & bind to family#10353
EvilOlaf merged 2 commits into
armbian:mainfrom
EvilOlaf:rtl8723ds-7.2

Conversation

@EvilOlaf

@EvilOlaf EvilOlaf commented Aug 6, 2026

Copy link
Copy Markdown
Member

Description

  • remove various version guards to allow more recent versions by default. if it breaks it breaks...
  • rtl8723ds: update commit hash to include 7.2 compatibility rtl8723ds: restrict to rockchip64 since rockpi-s seems the only board still need this. hence allow other boards to use mainline driver

How Has This Been Tested?

  • build rockchip64-7.2 (rockpi-s in particular)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Bug Fixes
    • Improved driver compatibility with newer kernel versions for RTL8852BS and uwe5622 hardware.
    • Limited RTL8723DS support to compatible Rockchip 64-bit devices.
    • Updated RTL8723DS driver sources while preserving existing installation and patching behavior.

- remove various version guards to allow more recent versions by default. if it breaks it breaks...
- rtl8723ds: update commit hash to include 7.2 compatibility
rtl8723ds: restrict to rockchip64 since rockpi-s seems the only board still need this. hence allow other boards to use mainline driver
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The patch removes upper kernel-version limits for RTL8852BS and uwe5622. It restricts RTL8723DS to rockchip64 and updates its source commit.

Changes

Network driver gating

Layer / File(s) Summary
Kernel version gating
lib/functions/compilation/patch/drivers_network.sh
RTL8852BS remains enabled from kernel 6.1. Uwe5622 remains enabled from kernel 5.15. Both no longer use the < 7.3 limit.
RTL8723DS scope and source
lib/functions/compilation/patch/drivers_network.sh
RTL8723DS is restricted to the rockchip64 family and uses an updated source commit.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • armbian/build issue 9921 — The patch restricts RTL8723DS to the rockchip64 family.

Possibly related PRs

Suggested labels: Hardware

Suggested reviewers: igorpecovnik, iav

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes to version guards and RTL8723DS support.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Aug 6, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/functions/compilation/patch/drivers_network.sh`:
- Line 518: Update the uwe5622-related comments and display_alert text to state
the actual supported kernel range beginning at 5.15. In the surrounding
compatibility condition, retain an upper 7.1 kernel guard if driver_uwe5622
support remains limited to that version; otherwise leave the existing
at-or-above-5.15 behavior consistent with the updated messages.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ae8185bb-34bc-4def-bc86-4163d42eb5c5

📥 Commits

Reviewing files that changed from the base of the PR and between 61ba9d2 and 186c1e3.

📒 Files selected for processing (1)
  • lib/functions/compilation/patch/drivers_network.sh

Comment thread lib/functions/compilation/patch/drivers_network.sh
@github-actions github-actions Bot added the 08 Milestone: Third quarter release label Aug 6, 2026
@EvilOlaf

EvilOlaf commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

depends on armbian/rtl8723ds#9

@EvilOlaf
EvilOlaf merged commit d28c4c8 into armbian:main Aug 10, 2026
14 of 15 checks passed
@EvilOlaf
EvilOlaf deleted the rtl8723ds-7.2 branch August 10, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Framework Framework components Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants