drivers_network.sh remove version guards, rtl8723ds update hash & bind to family - #10353
Conversation
- remove various version guards to allow more recent versions by default. if it breaks it breaks... - rtl8723ds: update commit hash to include 7.2 compatibility rtl8723ds: restrict to rockchip64 since rockpi-s seems the only board still need this. hence allow other boards to use mainline driver
📝 WalkthroughWalkthroughThe patch removes upper kernel-version limits for RTL8852BS and uwe5622. It restricts RTL8723DS to ChangesNetwork driver gating
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/functions/compilation/patch/drivers_network.sh`:
- Line 518: Update the uwe5622-related comments and display_alert text to state
the actual supported kernel range beginning at 5.15. In the surrounding
compatibility condition, retain an upper 7.1 kernel guard if driver_uwe5622
support remains limited to that version; otherwise leave the existing
at-or-above-5.15 behavior consistent with the updated messages.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ae8185bb-34bc-4def-bc86-4163d42eb5c5
📒 Files selected for processing (1)
lib/functions/compilation/patch/drivers_network.sh
|
depends on armbian/rtl8723ds#9 |
Description
How Has This Been Tested?
Checklist:
Summary by CodeRabbit