boards: promote tested boards to conf + maintainer cleanup - #10368
Conversation
Both run in the Armbian autotests hardware fleet (inventory run 31256580232 — discovered, reconciled, exercised on real hardware), so they carry ongoing automated boot/upgrade/perf coverage. Promote from community (.csc) to supported (.conf); BOARD_MAINTAINER=igorpecovnik. Rename only; board configs otherwise unchanged. Signed-off-by: Igor Pecovnik <igor@armbian.com>
Remove these handles from BOARD_MAINTAINER on the boards that listed them; each was the sole maintainer, so the field becomes empty: nanopiduo (sgjava), nanopineocore2 (AGM1968), orangepizero2 (AGM1968 krachlatte), radxa-e25 (krachlatte) Signed-off-by: Igor Pecovnik <igor@armbian.com>
Rename only; board config and maintainers (SuperKali sdeleeuw) unchanged. Signed-off-by: Igor Pecovnik <igor@armbian.com>
Rename only; board config unchanged. Signed-off-by: Igor Pecovnik <igor@armbian.com>
Rename only; board config and maintainer (rpardini) unchanged. Signed-off-by: Igor Pecovnik <igor@armbian.com>
Signed-off-by: Igor Pecovnik <igor@armbian.com>
📝 WalkthroughWalkthroughAdds board configurations for Arduino UNO Q, Radxa E24C, Cubox i, and Udoo. It also updates maintainer metadata for five existing boards and adds platform-specific installation, BSP, firmware, and U-Boot configuration. ChangesBoard support
Estimated code review effort: 3 (Moderate) | ~30 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant BuildSystem
participant ArduinoUNOQHooks
participant TargetImage
BuildSystem->>ArduinoUNOQHooks: run post-install and BSP hooks
ArduinoUNOQHooks->>TargetImage: install packages and systemd services
ArduinoUNOQHooks->>TargetImage: add Mesa pinning and Adreno firmware
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/boards/radxa-e24c.conf`:
- Line 1: Update the first-line descriptor in config/boards/radxa-e24c.conf at
lines 1-1 to include the exact RK3528 core count, supported RAM options, and
existing key hardware features. Update the descriptor in config/boards/udoo.conf
at lines 1-1 by replacing the generic “iMx” label with “i.MX6”.
- Line 9: Update the Radxa E24C board configuration near KERNEL_TARGET by adding
KERNEL_TEST_TARGET with only the kernel branch(es) that passed hardware
validation; remove any untested branch from the tested-target declaration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 184b48b0-7995-4e7c-94f7-e169d381dce3
📒 Files selected for processing (9)
config/boards/arduino-uno-q.confconfig/boards/cubox-i.confconfig/boards/lime-a64.confconfig/boards/nanopiduo.cscconfig/boards/nanopineocore2.cscconfig/boards/orangepizero2.cscconfig/boards/radxa-e24c.confconfig/boards/radxa-e25.confconfig/boards/udoo.conf
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/boards/radxa-e24c.conf`:
- Line 1: Update the first-line descriptor in config/boards/radxa-e24c.conf at
lines 1-1 to include the exact RK3528 core count, supported RAM options, and
existing key hardware features. Update the descriptor in config/boards/udoo.conf
at lines 1-1 by replacing the generic “iMx” label with “i.MX6”.
- Line 9: Update the Radxa E24C board configuration near KERNEL_TARGET by adding
KERNEL_TEST_TARGET with only the kernel branch(es) that passed hardware
validation; remove any untested branch from the tested-target declaration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 184b48b0-7995-4e7c-94f7-e169d381dce3
📒 Files selected for processing (9)
config/boards/arduino-uno-q.confconfig/boards/cubox-i.confconfig/boards/lime-a64.confconfig/boards/nanopiduo.cscconfig/boards/nanopineocore2.cscconfig/boards/orangepizero2.cscconfig/boards/radxa-e24c.confconfig/boards/radxa-e25.confconfig/boards/udoo.conf
🛑 Comments failed to post (2)
config/boards/radxa-e24c.conf (2)
1-1: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Complete the hardware descriptors.
The first-line descriptor is used during interactive compilation. It must state the exact SoC model, core count, RAM options, and key hardware features.
config/boards/radxa-e24c.conf#L1-L1: Add the RK3528 core count and supported RAM options.config/boards/udoo.conf#L1-L1: Replace genericiMxwithi.MX6.Based on learnings, board descriptors must provide complete and accurate hardware information.
🧰 Tools
🪛 GitHub Check: Validate changed board configs
[warning] 1-1:
KERNEL_TEST_TARGET: recommended, comma-separated list of branches to test (e.g. current,edge)📍 Affects 2 files
config/boards/radxa-e24c.conf#L1-L1(this comment)config/boards/udoo.conf#L1-L1🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@config/boards/radxa-e24c.conf` at line 1, Update the first-line descriptor in config/boards/radxa-e24c.conf at lines 1-1 to include the exact RK3528 core count, supported RAM options, and existing key hardware features. Update the descriptor in config/boards/udoo.conf at lines 1-1 by replacing the generic “iMx” label with “i.MX6”.Source: Learnings
9-9: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash set -euo pipefail # Trace how board validation and test selection consume KERNEL_TEST_TARGET. rg -n -C 3 'KERNEL_TEST_TARGET|radxa-e24c' config .Repository: armbian/build
Length of output: 50370
🏁 Script executed:
#!/bin/bash set -euo pipefail printf '--- radxa-e24c board config ---\n' sed -n '1,80p' config/boards/radxa-e24c.conf printf '\n--- exact kernel test target declarations in all board configs ---\n' rg -n 'KERNEL_TEST_TARGET=' config/boards/*.conf config/boards/*.csc config/boards/*.tvb 2>/dev/null || true printf '\n--- occurrences of KERNEL_TEST_TARGET usages outside board configs ---\n' rg -n 'KERNEL_TEST_TARGET|KERNEL_TARGET|kernel_test_target|target.*KERNEL' --glob '!config/boards/**' .Repository: armbian/build
Length of output: 242
🏁 Script executed:
#!/bin/bash set -euo pipefail echo '--- radxa-e24c board config ---' sed -n '1,80p' config/boards/radxa-e24c.conf echo echo '--- exact kernel test target declarations in board configs ---' rg -n '^[-[:space:]]*KERNEL_TEST_TARGET=' config/boards/*.conf config/boards/*.csc config/boards/*.tvb 2>/dev/null || true echo echo '--- occurrences of KERNEL_TEST_TARGET usages outside board configs ---' rg -n 'KERNEL_TEST_TARGET|KERNEL_TARGET|kernel_test_target|target.*KERNEL' --glob '!config/boards/**' .Repository: armbian/build
Length of output: 50370
🏁 Script executed:
#!/bin/bash set -euo pipefail echo '--- radxa-e24c board config ---' sed -n '1,20p' config/boards/radxa-e24c.conf echo echo '--- validate-board-config KERNEL_TARGET/KERNEL_TEST_TARGET logic ---' sed -n '95,195p' tools/validate-board-config.pyRepository: armbian/build
Length of output: 5167
Declare the tested kernel branch.
KERNEL_TARGET=edge,vendordeclares kernels to build, butconfig/boards/radxa-e24c.confomitsKERNEL_TEST_TARGET. Add the tested branch(es) if any passed hardware validation, and remove a target if it has not been tested.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@config/boards/radxa-e24c.conf` at line 9, Update the Radxa E24C board configuration near KERNEL_TARGET by adding KERNEL_TEST_TARGET with only the kernel branch(es) that passed hardware validation; remove any untested branch from the tested-target declaration.Source: Linters/SAST tools
Promote to supported (
.conf)Boards exercised on real hardware in the Armbian autotests fleet, promoted from community/wip to supported:
cubox-iudooarduino-uno-qlime-a64radxa-e24cMaintainer cleanup
Drop inactive maintainers (
sgjava,AGM1968,krachlatte) — each was the sole maintainer, so the field becomes empty:nanopiduo(sgjava),nanopineocore2(AGM1968),orangepizero2(AGM1968 krachlatte),radxa-e25(krachlatte)All changes are renames /
BOARD_MAINTAINERedits only — no board config behaviour changes.Summary by CodeRabbit
New Features
Maintenance