Skip to content

Enable (=m) USB serial, ACM, printer support for RV1106/RK3506 families - #10388

Merged
igorpecovnik merged 1 commit into
armbian:mainfrom
vidplace7:cdc_acm_rockchip
Aug 10, 2026
Merged

Enable (=m) USB serial, ACM, printer support for RV1106/RK3506 families#10388
igorpecovnik merged 1 commit into
armbian:mainfrom
vidplace7:cdc_acm_rockchip

Conversation

@vidplace7

@vidplace7 vidplace7 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Description

Enable USB serial, cdc_acm and printer support. Required for addressing USB printers on RV1106 and RK3506 families.

How Has This Been Tested?

  • luckfox-pico-mini trixie, compile tested
  • luckfox-lyra-zero-w trixie, compile tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Summary by CodeRabbit

  • New Features
    • Added support for USB ACM (serial) devices and USB printers.
    • Enabled USB serial support as loadable modules for improved flexibility.
    • Retained support for USB storage and DWC2 controllers.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • Needs review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 34d880ea-e1ca-45b6-a691-d9ec711aea29

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR updates two Rockchip vendor kernel configurations. USB ACM, printer, and serial drivers are enabled as loadable modules. Existing USB storage and controller support remains enabled.

Changes

USB kernel configuration

Layer / File(s) Summary
Enable USB driver modules
config/kernel/linux-rockchip-rv1106-vendor.config, config/kernel/linux-rockchip-vendor.config
Adds modular USB ACM, printer, and serial drivers. Changes RV1106 USB serial support from built in to modular. Retains existing USB storage and controller support.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: size/small

Suggested reviewers: amazingfate, paolosabatino, igorpecovnik

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change by naming the USB serial, ACM, and printer support enabled for the affected hardware families.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added 08 Milestone: Third quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... and removed size/small PR with less then 50 lines labels Aug 9, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/kernel/linux-rockchip-rv1106-vendor.config`:
- Around line 443-447: Add a usable USB-to-serial converter driver alongside
CONFIG_USB_SERIAL in both config/kernel/linux-rockchip-rv1106-vendor.config
lines 443-447 and config/kernel/linux-rockchip-vendor.config lines 468-472,
selecting CONFIG_USB_SERIAL_GENERIC with the appropriate built-in or module
setting for the target image, or the required chipset-specific driver. Ensure
both configurations provide an actual bound USB-serial driver, not only the
framework.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: edc5cd36-a76d-4181-89ee-0a4040315a2e

📥 Commits

Reviewing files that changed from the base of the PR and between 65669f8 and be1bc4a.

📒 Files selected for processing (2)
  • config/kernel/linux-rockchip-rv1106-vendor.config
  • config/kernel/linux-rockchip-vendor.config

Comment thread config/kernel/linux-rockchip-rv1106-vendor.config
@github-actions github-actions Bot added the size/small PR with less then 50 lines label Aug 9, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Aug 10, 2026
@igorpecovnik
igorpecovnik merged commit 68649f0 into armbian:main Aug 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

3 participants