Enable (=m) USB serial, ACM, printer support for RV1106/RK3506 families - #10388
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR updates two Rockchip vendor kernel configurations. USB ACM, printer, and serial drivers are enabled as loadable modules. Existing USB storage and controller support remains enabled. ChangesUSB kernel configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/kernel/linux-rockchip-rv1106-vendor.config`:
- Around line 443-447: Add a usable USB-to-serial converter driver alongside
CONFIG_USB_SERIAL in both config/kernel/linux-rockchip-rv1106-vendor.config
lines 443-447 and config/kernel/linux-rockchip-vendor.config lines 468-472,
selecting CONFIG_USB_SERIAL_GENERIC with the appropriate built-in or module
setting for the target image, or the required chipset-specific driver. Ensure
both configurations provide an actual bound USB-serial driver, not only the
framework.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: edc5cd36-a76d-4181-89ee-0a4040315a2e
📒 Files selected for processing (2)
config/kernel/linux-rockchip-rv1106-vendor.configconfig/kernel/linux-rockchip-vendor.config
be1bc4a to
95bc018
Compare
|
✅ This PR has been reviewed and approved — all set for merge! |
Description
Enable USB serial, cdc_acm and printer support. Required for addressing USB printers on RV1106 and RK3506 families.
How Has This Been Tested?
luckfox-pico-minitrixie, compile testedluckfox-lyra-zero-wtrixie, compile testedChecklist:
Summary by CodeRabbit