Skip to content

meson64-6.12: oldlts: update meson-axg mmc phase configuration patch#9712

Merged
igorpecovnik merged 1 commit intoarmbian:mainfrom
rpardini:pr/meson64-612-oldlts-update-meson-axg-mmc-phase-configuration-patch
Apr 23, 2026
Merged

meson64-6.12: oldlts: update meson-axg mmc phase configuration patch#9712
igorpecovnik merged 1 commit intoarmbian:mainfrom
rpardini:pr/meson64-612-oldlts-update-meson-axg-mmc-phase-configuration-patch

Conversation

@rpardini
Copy link
Copy Markdown
Member

@rpardini rpardini commented Apr 23, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced Meson-AXG device tree configuration with optimized MMC/SD controller settings by refining clock phase timing parameters and adjusting base clock rates. These changes improve hardware compatibility, enhance system stability, and extend support for diverse SD and eMMC memory device implementations on Amlogic platforms.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 05d62825-dc54-434b-8a62-9987f4214262

📥 Commits

Reviewing files that changed from the base of the PR and between 2bb89c7 and e05883d.

📒 Files selected for processing (1)
  • patch/kernel/archive/meson64-6.12/general-meson-mmc-2-arm64-amlogic-dts-meson-update-meson-axg-device-tree.patch

📝 Walkthrough

Walkthrough

This patch updates the Meson-AXG device tree source to configure MMC controller clock phases and assigned clock rates. The changes add MMC phase bindings, set core phase to CLK_PHASE_270, and assign the SD/eMMC clock to 24000000 Hz for both sd_emmc_b and sd_emmc_c controllers.

Changes

Cohort / File(s) Summary
Meson-AXG DTS MMC Configuration
arch/arm64/boot/dts/amlogic/meson-axg.dtsi
Added include directive for MMC phase clock binding constants; configured amlogic,mmc-phase properties with CLK_PHASE_270 core phase for both sd_emmc_b and sd_emmc_c nodes; assigned clock rates to 24000000 via assigned-clocks and assigned-clock-rates properties.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops through device trees so grand,
With phase shifts and clocks in each hand,
MMC controllers now dance just right,
At 24 MHz, clear and bright! 🐰⏱️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the meson-axg MMC phase configuration patch for the meson64-6.12 kernel release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rpardini rpardini marked this pull request as ready for review April 23, 2026 09:24
@github-actions github-actions Bot added 05 Milestone: Second quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... size/small PR with less then 50 lines labels Apr 23, 2026
@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Apr 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Apr 23, 2026
@igorpecovnik igorpecovnik merged commit 55706c5 into armbian:main Apr 23, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants