Process_CI: fix broken release-target links (wrong branch + workflow name) - #952
Merged
Merged
Conversation
…ame) The generated release-target YAMLs live on the `data` branch at `data/release-targets/`, not on `main/release-targets/` (which only holds the `.blacklist`/`.manual`/`.map` sources), so these links 404: - targets-release-standard-support.yaml (×2) - targets-release-apps.yaml (×2) Point them at `blob/data/data/release-targets/...`, matching the already-correct nightly link. Also fix the "generate-targets workflow" link: there is no `generate-targets.yaml` on armbian.github.io; the workflow that runs `generate_targets.py` is `generate-build-lists.yaml`. Signed-off-by: Igor Pecovnik <igor@armbian.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated five CI documentation links in Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…efix) github.armbian.com serves the data branch at root, so data/release-targets/X is published as github.armbian.com/release-targets/X. The link used github.armbian.com/data/release-targets/kernel-description.json which 404s; drop the data/ prefix. Signed-off-by: Igor Pecovnik <igor@armbian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Several links in Process_CI › Prepare Standard Support images for release (and the apps section) 404.
Why
The generated release-target YAMLs live on the
databranch atdata/release-targets/, not onmain/release-targets/(which only contains the.blacklist/.manual/.mapsource files). Verified via the GitHub API:armbian.github.io@main:release-targets/→ has*.blacklist,*.manual,targets-extensions.map— no*.yamlarmbian.github.io@data:data/release-targets/→ hastargets-release-standard-support.yaml,targets-release-apps.yaml,targets-release-nightly.yaml, …The nightly link in the same doc was already correct (
blob/data/data/release-targets/…); this just makes standard-support and apps consistent.Fixes
blob/main/release-targets/targets-release-standard-support.yaml(×2)blob/data/data/release-targets/targets-release-standard-support.yamlblob/main/release-targets/targets-release-apps.yaml(×2)blob/data/data/release-targets/targets-release-apps.yaml[generate-targets workflow](…/generate-targets.yaml)[generate-build-lists workflow](…/generate-build-lists.yaml)generate-targets.yamldoesn't exist on armbian.github.io;generate-build-lists.yamlis the workflow that actually runsgenerate_targets.py.Documentation website preview will be available shortly:
Open WWW preview