Skip to content

feat(Search): track SearchedWithNoResults on /search zero-results page; bump cohesion - #17521

Merged
nickskalkin merged 1 commit into
mainfrom
nickskalkin/no-results-tracking
Jul 28, 2026
Merged

feat(Search): track SearchedWithNoResults on /search zero-results page; bump cohesion#17521
nickskalkin merged 1 commit into
mainfrom
nickskalkin/no-results-tracking

Conversation

@nickskalkin

@nickskalkin nickskalkin commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The type of this PR is: Feat

This PR solves ONYX-2200

Description

  • Fire the SearchedWithNoResults cohesion event from SearchApp when a search on /search returns zero results (the ZeroState / "No results found for ..." view). Previously this event only fired from the autosuggest search bar, so no-results searches submitted directly to the results page weren't tracked.
  • context_owner_type is search, context_module is searchPageResults
  • bumps cohesion

@nickskalkin
nickskalkin requested a review from a team July 28, 2026 06:21
@nickskalkin nickskalkin self-assigned this Jul 28, 2026
bump cohesion

Autosuggest already fires this event; the full-page /search results
view (ZeroState) didn't, leaving no-results searches invisible in
analytics.

Assisted-by: Claude <noreply@anthropic.com>
@nickskalkin
nickskalkin force-pushed the nickskalkin/no-results-tracking branch from 8c6b3c7 to 20f3aab Compare July 28, 2026 07:28
@relativeci

relativeci Bot commented Jul 28, 2026

Copy link
Copy Markdown

#9390 Bundle Size — 8.99MiB (~+0.01%).

20f3aab(current) vs 152899e main#9384(baseline)

Warning

Bundle contains 29 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#9390
     Baseline
#9384
Regression  Initial JS 2.94MiB(~+0.01%) 2.94MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 97.49% 97.49%
No change  Chunks 110 110
No change  Assets 113 113
No change  Modules 5668 5668
No change  Duplicate Modules 661 661
No change  Duplicate Code 4.92% 4.92%
No change  Packages 248 248
No change  Duplicate Packages 28 28
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#9390
     Baseline
#9384
Regression  JS 8.76MiB (~+0.01%) 8.76MiB
No change  Other 231.04KiB 231.04KiB

Bundle analysis reportBranch nickskalkin/no-results-trackingProject dashboard


Generated by RelativeCIDocumentationReport issue

@nickskalkin
nickskalkin merged commit 9605142 into main Jul 28, 2026
12 checks passed
@nickskalkin
nickskalkin deleted the nickskalkin/no-results-tracking branch July 28, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants