chore(pr-template): add §1.7 forward+backward stubs + Skipped guidance - #33
Merged
Conversation
The discipline-self-check CI gate (.github/workflows/discipline-self-check.yml) fires on every `pull_request` event whose paths-filter matches one of: - .claude/rules/** - packages/core/principles/** - docs/meta-factory/EXECUTION-PLAN.md - docs/meta-factory/prior-art-evaluations.md - CLAUDE.md - templates/**/*.md, packages/core/templates/** and requires PR body to carry either exact H3 sections `### §1.7 Forward-check applied` + `### §1.7 Backward-check applied` (≥40 non-whitespace chars each) OR a `### §1.7 Skipped: <reason ≥60 chars>` shortcut. The requirement was documented only in .claude/rules/phase-research-coverage.md §1.7 and a kickoff prompt — PR authors keep missing it on first attempt (kickoff:97 «Wave 2 PR #22 had to be fixed for this — do NOT repeat»; #32 fixed mid-flight as well). Adds a §1.7 section to .github/pull_request_template.md with: - HTML-comment block explaining the gate (paths-filter, char minima, skip syntax) - Two H3 stubs with placeholder text deliberately under 40 non-whitespace chars (`_TODO: enumerate disciplines checked_` = 34 chars; `_TODO: enumerate sweep performed_` = 30 chars). CI still fails until author replaces — placeholders do NOT bypass the gate, only make the requirement visible at template load. - Inline instructions to DELETE both H3 stubs and replace with a single `### §1.7 Skipped:` line if the PR does not touch any discipline-bearing file. This PR's own body does NOT need §1.7 sections — discipline-self-check paths-filter excludes `.github/**`, so the gate does not fire here. Not a capability commit per CLAUDE.md: no new dep, no new ≥50 LOC under new packages/core/<new-dir>/, no new ≥80 LOC under packages/. Template prose edit only. Prior-art: skipped — operator-side enforcement-layer template edit (parallel to .husky/pre-push pre-existing guidance), no new capability surface; reduces recurring §1.7 CI fail caught in PRs #22/#32 + kickoff:97 warning.
Merged
4 tasks
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a §1.7 self-discipline section to
.github/pull_request_template.mdto eliminate the recurring discipline-self-check fail observed across PRs (kickoff:97 «Wave 2 PR #22», #32 mid-flight body fix).Why
discipline-self-check.ymlfires on everypull_requestevent whose paths-filter matches.claude/rules/**,packages/core/principles/**,EXECUTION-PLAN.md,prior-art-evaluations.md,CLAUDE.md, or shipped templates — and requires either:### §1.7 Forward-check applied+### §1.7 Backward-check applied(≥40 non-whitespace chars each), OR### §1.7 Skipped: <reason ≥60 chars>shortcut on a single line.The requirement lived only in
.claude/rules/phase-research-coverage.md §1.7and an orchestrator kickoff prompt. Authors keep missing it on the first try; the user explicitly flagged the recurrence («каждый PR ловит эту ошибку»).Changes
_TODO: enumerate disciplines checked_= 34 chars;_TODO: enumerate sweep performed_= 30 chars). Placeholders do NOT bypass the gate — CI still fails until the author replaces them. They make the requirement visible at template load.### §1.7 Skipped:line if the PR does not touch any discipline-bearing file.Why this PR doesn't need §1.7 sections in its own body
discipline-self-checkpaths-filter excludes.github/**— the gate does not fire on this PR. (The PR template is enforcement-layer infra, parallel to.husky/pre-pushand.github/workflows/, not a discipline-bearing rule itself.) The new stubs will apply starting with the next PR opened after this one merges.How to verify
discipline-self-check(paths-filter excludes.github/**)### §1.7 Skipped: <≥60 chars>line → CI passes