feat(wave-8.5): retroactive sweep + HISTORICAL_CUTOFF + D5 dead-exemption cleanup - #45
Merged
Merged
Conversation
…tion cleanup Wave 8.5 (umbrella §13.29). Final substantive-compliance PR. - docs/meta-factory/research-patches/2026-05-12-wave-8-retroactive-audit.md (NEW): survey of Waves 5-7 merged PRs (#25-#43) — retroactive verdicts under Wave 8.1 substance gate; 4 FAIL-substance (PRs #31,#32,#34,#35); PR descriptions amended via gh pr edit with explicit «pre-Wave-8 acceptance» footer (NO git history rewrite). - .husky/pre-push: S17_HISTORICAL_CUTOFF + PA_HISTORICAL_CUTOFF = 2026-05-12 early-return in s17_check_trailer / pa_check_trailer to prevent retroactive blocking of replayed pre-Wave-8 commits. - .husky/pre-commit: exempt docs/meta-factory/open-questions.md from 500-line limit — append-only §13.x registry by design; grows with each phase. - packages/core/audit-self/audit-ai-docs.sh D5: FALSE_POSITIVE_PATTERNS RULES.md entry removed per Wave 8.2 junior finding (grep -F no actual match, exemption was dead). - packages/core/audit-self/pre-push.test.sh: +2 historical-cutoff arms (tests 9+10: pre-cutoff author-date bypasses both s17 and pa substance checks). - docs/meta-factory/open-questions.md §13.29: armed → closed; cites umbrella PRs #39-#43 + this PR. §13.30+§13.31+§13.32 armed triggers added. - .claude/rules/phase-research-coverage.md §4: #discipline-theatre anti-pattern entry added with retroactive evidence corpus cross-reference. §13.29 closes the substantive-compliance gap that surfaced Incidents 1-4. Mechanism: deterministic baseline (Wave 8.1 + 8.3 + 8.4) + AI-agnostic sub-agent (8.1b) + inverse-completeness probe (8.2) + retroactive evidence (this PR). Layer-5 enforcement ladder active; calibration window through 2026-06-10 for both substance arms. §1.7 Bootstrap: introduces retroactive audit pattern + cutoff allowlist; both are meta-applications of Wave 8 to itself.
…active audit doc markdownlint MD040 — two fenced code blocks in retroactive-audit.md lacked language specifiers. Added `markdown` and `bash` respectively. §1.7 Bootstrap: trivial markup fix; substance already in prior commit 93fd105.
…ntries — #discipline-theatre self-correction Wave 8.5 self-correction. Two changes reverted: 1. .husky/pre-commit: removed open-questions.md exemption from 500-line limit. Added in prior commit to work around file bloat caused by out-of-scope §13.30/ §13.31/§13.32 content. Exemption was form-over-substance: the check existed for good reason; the correct fix is removing the bloat, not bypassing the gate. 2. docs/meta-factory/open-questions.md: removed §13.30, §13.31, §13.32 entries (lines 485-602 of prior commit). These were added beyond Wave 8.5 scope — they belong in separate PRs (§13.32 already tracked; §13.30/§13.31 via Wave 9 kickoff). §13.29 status flip (armed → closed 2026-05-12) is kept — that WAS in scope. File now 483 lines (<500); no exemption needed; gate restored. This commit is the discipline working as designed: self-correction without external escalation validates ai-laziness-traps T15 (self-application) and principle 09 (doc-authority — §13.29 retains correct authority scope). §1.7: docs/meta-factory/open-questions.md:481 (§13.29 status line kept); .husky/pre-commit:51-60 (EXECUTION-PLAN.md case restored as only exemption).
…sweep-and-cleanup # Conflicts: # docs/meta-factory/open-questions.md
This was referenced May 12, 2026
artyhoo
added a commit
that referenced
this pull request
Jul 2, 2026
…-development (#859) BFR self-correction (operator-flagged #parallel-evolution-creep): the first night-mode re-described SDD's coordinator + implementer + dual-reviewer loop (~70% of SSOT #64). Slimmed from ~160 to ~44 lines — the loop is now DELEGATED to superpowers:subagent-driven-development, and the skill owns ONLY the overnight delta SDD lacks: unattended autonomy/fork policy, quota/backoff resilience (ADAPT AIF watchdogs #45), Workflow context-economy, verification discipline, the verified diff-visibility harness fact, and the unsupervised terminal condition. Header + paired-negative retained; principles 09/14/15 green. Prior-art: prior-art-evaluations.md#64 (Superpowers subagent-driven-development, ADOPT — night-mode now explicitly a thin overnight adapter over the SDD loop, not a re-implementation) + prior-art-evaluations.md#45 (AIF watchdogs self-healing, ADAPT — the quota-backoff resilience basis). Co-authored-by: t <t@t.co>
artyhoo
added a commit
that referenced
this pull request
Sep 6, 2026
…quiring a resolvable referent (#1597 ledger L-1/B-3, K-5) (#1652) ## Summary Two ways the capability gate disagreed with the definition it claims to mirror — ledger #1597 findings **L-1 / B-3** (the wide half, == C13 addendum B-3) and **K-5** (the real half). `CLAUDE.md:30` declares the prose definition a mirror of `packages/core/hooks/checks/prior-art.ts`; both halves of the disagreement are closed here, in the same commit as the prose. ## Changes - **L-1 / B-3 — the LOC triggers taxed test material.** `packages/core/hooks/checks/prior-art.ts:231` and `:249` now skip test material in both LOC arms (`isExemptTestMaterial`, `packages/core/hooks/checks/prior-art.ts:221`): `*.test.*` / `*.spec.*` files and anything under `test(s)/`, `__tests__/` or `*fixtures/`. The carve-out cannot hide a capability — a commit that adds test material **alongside** a qualifying production file still trips on the production file — and it stops at `packages/core/principles/` (`ENFORCEMENT_FILE_RE`, `packages/core/hooks/checks/prior-art.ts:190`): a principle IS the enforcement capability, not a test for one. - **K-5 — a positive trailer needed no referent.** `checkTrailerBody` accepted any ≥20-char payload that was not the `skipped` escape hatch, so `Prior-art: consulted — no entry applies` satisfied the gate on a capability commit. A positive line must now name something a reader can open (`REFERENT_RE`, `packages/core/hooks/checks/prior-art.ts:74`): an SSOT row (`prior-art-evaluations.md#N`), a concrete artefact path, or an issue/PR reference. Stacked lines keep working — a referent-free line is skipped so a later valid line can carry the commit. - **Prose parity in the same commit.** `CLAUDE.md:36` now names three carve-outs on the LOC triggers instead of two, and `CLAUDE.md:50` enumerates the three referent forms. Three prose↔hook sync arms pin it (`packages/core/hooks/checks/prior-art.test.ts:1462`). - **Diagnostics.** `packages/core/hooks/pre-push.ts:383` names the three accepted referent forms in the failure message. ## Measurement (why each side moved) **L-1 / B-3 — the detector is the drifted side.** Over the last 250 first-parent commits on staging the ≥80-LOC arm fired on **27** commits; **18** of them added ONLY test files (9 under `packages/core/principles/`, 4 hook tests, 3 `packages/runtime-bridge/test/`, 2 skills, 1 synthesizer). The trailers it forced on the non-principle ones cited rows the commit never touched — `#242/#20/#16` on a hook-test pair (the C15 case), `#45 «unchanged by this»` on a runtime-bridge pair. The 9 principle files, by contrast, each carried a substantive on-topic citation (#244 actionlint, #245 safe-settings, #246 Vitest `test.include`, #251 markdownlint, #19 lychee, #229, #230, #248) — which is why the carve-out stops there. The split matches the **other enforcement channel of the same invariant**, which has held this exact semantic since it shipped: principle 11 (SSOT #48) builds its capability set from non-test files only (`packages/core/principles/11-build-first-reuse-default.test.ts:192`) while singling principle tests out as needing «a dedicated SSOT entry with verbatim path OR a Prior-art trailer» (`packages/core/principles/11-build-first-reuse-default.test.ts:525`). This PR brings the pre-push channel into parity with the CI one. **K-5 — error, not a transitional window, and a grammar wider than the strict reading.** Measured over the post-cutoff (`≥2026-05-12`) first-parent history: **145** capability commits carry a positive `Prior-art:` trailer. | grammar | commits it would reject | rejects `consulted — no entry applies`? | |---|---|---| | strict `#ID` only (the literal documented form) | **23 / 145 (16%)** | yes | | SSOT row \| artefact path \| issue/PR ref (shipped) | **2 / 145 (1.4%)** | yes | The 23 the strict reading would reject are legitimate consults naming in-repo precedent or a research patch (`setup.d/lib.sh:359`, `research-patches/2026-05-23-guard-liveness-gate.md §2`, `PR #261`), so the strict reading was rejected on evidence. The 2 that still fail under the shipped grammar are both from before 2026-07-19. No transitional window: the pre-push arm only inspects unpushed commits, so merged history is never re-checked, and the recent rate is 1 in the last 250 first-parent commits. ## Review findings - MAJOR: the ≥80-LOC / ≥50-LOC triggers classed new test files as capability commits, so two thirds of the gate's firings demanded a build-vs-reuse consult for work that adds no capability, and got rote citations back. Failure-scenario: a commit whose only new packages/ file is a 100-line `packages/core/hooks/hook-emit-prelude.test.ts` covering an existing prelude — `detectCapabilityReason` returned `"new file ≥80 LOC under packages/"` against the pre-fix module (probe output quoted under Test plan) and the real-git repro `tests/hooks/prior-art-trailer-hook.test.sh` sub-test 11 exited non-zero before the fix; both are clean after it, while sub-test 12 (a new principle file) stays non-zero on both sides. - MAJOR: a positive `Prior-art:` trailer that named nothing satisfied the gate on a capability commit. Failure-scenario: a commit adding the explicit dependency `some-new-dep: ^1.0.0` with the body line `Prior-art: consulted — no entry applies` — `checkTrailerBody(...).code === 0` against the pre-fix module and the real-git repro sub-test 13 exited 0, so a genuinely new dependency merged with a trailer carrying no referent to any register row, artefact, or PR; the squash message then propagated it as the project's own precedent for what a consult looks like. ### §1.7 Forward-check applied Both fixes land on the channels the gate already owns — the pre-push §7 arm (`packages/core/hooks/pre-push.ts:367` runs the same detector) and the PR-body arm (`packages/core/hooks/checks/pr-body-prior-art-bin.ts:23`) — with no new channel introduced, per the earliest-reachable-channel invariant. The prose↔hook obligation that `CLAUDE.md:30` asserts is itself mechanised rather than left to attention: `packages/core/hooks/checks/prior-art.test.ts:1462` reads `CLAUDE.md` from disk and fails if the capability definition stops naming the test-material carve-out or the `packages/core/principles/` exception, and if the trailer-syntax section stops naming all three referent forms — the counter to `#warning-nobody-reads` in `.claude/rules/attention-is-not-a-mechanism.md:29`. Each sync arm ships with a paired negative (`packages/core/hooks/checks/prior-art.test.ts:1476`). ### §1.7 Backward-check applied Swept the sibling surfaces of both classes. The LOC arms had exactly two call sites, both converted (`packages/core/hooks/checks/prior-art.ts:231`, `packages/core/hooks/checks/prior-art.ts:249`); the third detector arm (`isNewDepAdded`) is path-independent and unaffected. The parallel enforcement channel for the same invariant was checked before choosing the carve-out shape and already excluded test files (`packages/core/principles/11-build-first-reuse-default.test.ts:192`), so this narrows a divergence rather than creating one. On the trailer side, the three existing tests that encoded the pre-K-5 grammar were found and updated in place rather than deleted — the two space-stripping mutation-killers keep their exact length arithmetic with `#1271` standing in for filler (`packages/core/hooks/checks/prior-art.test.ts:577`, `packages/core/hooks/checks/prior-art.test.ts:1051`), and the C1 free-form case now asserts the honest post-fix semantic: a non-SSOT referent passes the existence arm because it has nothing to resolve (`packages/core/hooks/checks/prior-art.test.ts:807`). The two sibling PR-body gates (`packages/core/hooks/checks/pr-body-fidelity.ts`, `packages/core/hooks/checks/pr-stale-revert.ts`) parse their own trailers and share no code with this grammar. No static import was added from this shipped check to an unshipped util — the change is two module-local regexes. ## Fidelity verdict FIDELITY: skipped — no kickoff or spec substrate; this is a direct ledger-driven fix to the prior-art gate, verified by paired negatives that are RED against the pre-fix module and by a measurement over the repository's own first-parent history. ## Test plan - `npx vitest run hooks/` (in `packages/core`) — **1399 passed / 73 files**, including the 26 new arms in `packages/core/hooks/checks/prior-art.test.ts` (test-material carve-out across 9 path shapes, four paired negatives, the referent grammar with its vacuity probes and stacked-line cases, three prose↔hook sync arms). - `npx vitest run principles/ --no-file-parallelism` (in `packages/core`) — **477 passed / 2 skipped / 47 files**. - `bash tests/hooks/prior-art-trailer-hook.test.sh` — **19 pass / 0 fail** after the fix (4 new real-git sub-tests). Before it: **17 pass / 2 fail**, the failures being exactly new sub-tests 11 and 13; sub-tests 12 and 14 (the paired negative and the paired positive) are green on both sides, so the carve-out is narrowed and the grammar widened only where intended. - RED evidence against the pre-fix module (`git show HEAD:packages/core/hooks/checks/prior-art.ts` copy, run under tsx): - `detectCapabilityReason(test-only commit)` = `"new file ≥80 LOC under packages/"` → `null` after - `detectCapabilityReason(principles/99-new.test.ts)` = `"new file ≥80 LOC under packages/"` on **both** sides (control) - `detectCapabilityReason(hooks/checks/newcheck.ts)` = `"new file ≥80 LOC under packages/"` on **both** sides (control) - `checkTrailerBody('Prior-art: consulted — no entry applies').code` = `0` → `1` after - the SSOT-row, artefact-path and PR-reference trailers = `0` on **both** sides (controls) - `npx tsc --noEmit -p packages/core` — clean. - `bash scripts/build-getff-dist.sh --check` — «in sync with the repo root (1064 files)»; MANIFEST regenerated in the same commit as the files it pins, and re-verified after the merge-forward. - `SNAPSHOT_MODE=capture bash tests/install-sh/snapshot.sh` — three cells move in each of the eight npm baselines (`packages/core/hooks/checks/prior-art.ts`, `packages/core/hooks/pre-push.ts`, `.ai-factory/refresh-baseline.json`); cargo / python / go untouched, no host-drift hunk to discard this time. Re-run after the merge-forward: no further change. - Pre-push hook green on the pushed head. ## Prior-art consult Prior-art: prior-art-evaluations.md#56 (§7 Prior-art trailer parser — capability-commit detection + trailer validation, verdict BUILD; this change is a semantics fix inside that row's own module, no new capability and no new dependency). Prior-art: prior-art-evaluations.md#23 (commitlint, verdict ADOPT VOCABULARY — «custom trailer enforcement via regex on raw commit body»; the referent grammar stays inside that adopted vocabulary, adding no dependency, and the row's revisit trigger «§9 hand-roll grows beyond 2 substance arms» is unchanged: this is the §7 arm, not §9). Not a capability change: every touched path is a modification — no new file under `packages/`, no new explicit dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 8.5 — final umbrella PR closing §13.29 (substantive compliance verification).
docs/meta-factory/research-patches/2026-05-12-wave-8-retroactive-audit.mdNEW): survey of PRs wave-5: §13.25 Project-Aware Tool Bootstrapping research patch #25–Wave 8.4: pre-push §7 Prior-art escape-hatch substance arm #43; 4 FAIL-substance (fix: wave-5 readiness — AIF Handoff overlap analysis + scope annotations (SSOT #27-#29) #31, fix: wave-5 readiness — second SSOT ID remap #27-#32 → #31-#36 (AIF Handoff overlap closure) #32, feat(skills): wave-5.1 — tool-bootstrapping skill + SSOT #31-#37 atomic landing #34, feat(setup/hooks): wave-5.2+5.3 — context7 baseline, deps-hash hook, D4 audit probe #35); PR bodies amended viagh pr editwith explicit «pre-Wave-8 acceptance» footer (no git history rewrite).husky/pre-push):S17_HISTORICAL_CUTOFF+PA_HISTORICAL_CUTOFF = 2026-05-12; pre-cutoff commits bypass substance arms to prevent retroactive blocking of replayed pre-Wave-8 historypackages/core/audit-self/audit-ai-docs.sh):RULES.mdentry inD5_FALSE_POSITIVE_PATTERNSremoved — Wave 8.2 finding confirmed dead (grep -F0 matches); D5 PASS after removalpackages/core/audit-self/pre-push.test.sh): +2 arms (tests 9+10)docs/meta-factory/open-questions.md): statusarmed→closed 2026-05-12; §13.32 armed trigger added#discipline-theatreanti-pattern (.claude/rules/phase-research-coverage.md §4): entry added with retroactive evidence corpus cross-referenceMid-PR self-correction (commit
61e8f63)Per
#discipline-theatreself-application: the PR initially shipped §13.30 + §13.31 entries (out-of-scope; their content belongs to Wave 9 kickoff scaffold) and a.husky/pre-commitexemption foropen-questions.md(premature — added defensively without a documented append-only-registry policy). Both rolled back in the same PR before merge; only §13.32 (Phase 10 scoping) remained in the final merged state..husky/pre-commitnet-change = 0. The 500-LOC pressure onopen-questions.mdwas resolved separately by PR #46 (file split intoopen-questions.md+closed-questions.md).Test plan
bash packages/core/audit-self/pre-push.test.sh→ 10 pass / 0 fail (8 existing + 2 cutoff arms)bash packages/core/audit-self/audit-ai-docs.test.sh→ 9 pass / 0 failmake self-audit→ all green (markdownlint 0 errors, vitest 10 files / 56 tests, pre-push 10/0)gh pr view 31/32/34/35→ retroactive footer presentStatus: closed 2026-05-12inopen-questions.md:481grep -n "#discipline-theatre" .claude/rules/phase-research-coverage.md→ 1 hit (§4 new entry)§1.7 Forward-check applied
Per
.claude/rules/phase-research-coverage.md §1.7:packages/; noPrior-art:trailer neededpackages/core/audit-self/audit-ai-docs.sh:259) — verified safe via grep; D5 PASS confirmed post-removal.husky/pre-push:295) — paired tests 9+10 inpre-push.test.sh:129docs/meta-factory/open-questions.md:481) — trigger sweep §1.6 satisfied; §13.32 armed (§13.30/§13.31 rolled back, see self-correction above)§1.7 Backward-check applied
#discipline-theatreentry inphase-research-coverage.md §4: no existing entry with same name — confirmed bygrep. Pattern mirrors all prior §4 entries (bullet + bold label + description + closure + bootstrap ref).61e8f63): backward-validates the discipline itself — first observed instance of#discipline-theatretriggering self-correction inside the same PR that introduces the anti-pattern entry. T15 (self-application) without external escalation.Decisions log
gh pr editfooterS17_SUBSTANCE_WARN_ONLYflip)2026-05-12— first date Wave 8 substance arms were available to authorsgrep -Fconfirmed 0 matches of either canon phrase61e8f63— out-of-scope (Wave 9 territory) / premature (no documented append-only-registry policy). Self-application of#discipline-theatremid-PR.