refactor(install): S1 — framework-only install.sh (one-click-installer Stage 1) - #442
Merged
Merged
Conversation
artyhoo
enabled auto-merge (squash)
June 10, 2026 11:51
This was referenced Jun 10, 2026
artyhoo
added a commit
that referenced
this pull request
Jun 10, 2026
…with ./setup reality Carried fixes from S4 GO: (1) BFR §1.1 opt-in seam is now the ./setup companion-manifest flow (companion blocks left install.sh in S1 #442; ./setup + setup.d shipped #443-#447); (2) doc-authority-hierarchy §2 install.sh:138-152 citation updated to the verified SHIPPED_DOCS copy/validate range install.sh:89-128.
This was referenced Jun 10, 2026
artyhoo
added a commit
that referenced
this pull request
Jun 11, 2026
…no-arg) (#462) DRIFT-1 aif-worktree-gap/aif-isolation ✅ (#372/#386/#387); DRIFT-2 N6b/one-click-installer ✅ (#442–#452/#453); DRIFT-3 f2-aif-fire-backend-iphase ✅ (#457/#459); DRIFT-4 NEW guard-liveness umbrella row (Stage 1 ✅ #458/#460, Stage 2 v1.5‖v3 unblocked, Stage 3 v2 gated). Human-directed §0 write (Direction B). Pushed via Git Data API — local pre-push blocked by 2 unrelated gitignored kickoffs (cross-worktree-symlink-iphase, worktree-cleanup-migration) lacking §5; outside this doc-only diff. Prior-art: skipped — doc-only §0 status reconciliation, no new capability or dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage S1 of the one-click-installer umbrella (plan:
docs/superpowers/plans/2026-05-31-one-click-installer.mdTask 1, merged #441). Reducesinstall.shto framework-only: the three companion-install blocks (Superpowers / TaskMaster / OhMyOpencode) and the--companionsarg machinery move out — companion selection migrates to the upcoming./setupmanifest (S2/S3).Changes
install.sh−128 LOC: deleted section 3.5 «Optional companion installs» in full (header comment → closingfi, incl. the non-interactiveCOMPANIONS=nonefallback) +COMPANIONSinit/arg-parse. The# ── aif-handoff integration noteblock survives intact (framework skill-context, not a companion install).tests/install-sh/no-companion-blocks.test.sh(verbatim from plan Task 1 Step 1): 4 assertions that install.sh carries no companion-install logic. Red-phase verified before trim (PASS=0 FAIL=4), green after (PASS=4 FAIL=0).Prior-art consult
refactor(install)commit; no new dep, no new ≥50/80-LOC module underpackages/). Prior-art for the umbrella's capability stages lives in spec §10/§11 (aif-handoffinstallMcpServerprecedent) and lands with S2+.Test plan
bash tests/install-sh/no-companion-blocks.test.sh→PASS=4 FAIL=0(worker verify-trace, red→green TDD cycle evidenced)bash -n install.sh→ exit 0 (worker verify-trace)install.sh ts-server --dry-runin throwaway dir, non-interactive (</dev/null) → exit 0, «✅ Dry-run complete. Nothing was written.», zero companion prompts (grep on full output:companion|superpowers|taskmaster|ohmyopencode|[y/N]→ 0 matches)tests/install-sh/transform-internal-refs.test.sh→ 7 pass / 0 failgrep -ni 'companion\|COMPANIONS' install.sh→ zero matches; paid-by-default sweep (T-OCI-B): no surviving auto-install path of any companion (remainingclaude plugin-shaped strings are echo-only next-steps prose)ci-successgate on this PR (pending — runs on PR)§1.7 Self-discipline check (REQUIRED if PR touches discipline-bearing files)
§1.7 Skipped: refactor-only trim of install.sh + paired TDD test; no discipline-bearing surface (rules/principles/templates) touched.
🟢 Простыми словами
install.shтеперь ставит только сам фреймворк и больше не предлагает установить компаньоны (Superpowers и др.) — этим займётся единая команда./setup, которую добавят следующие стадии. Поведение зафиксировано тестом из 4 проверок.Observations (out of scope, per CLAUDE.md PR strategy)
tail -5, but install.sh prints the next-steps block AFTER that marker (pre-existing output order; marker at line 55/77 of the dry-run log). Plan expectation imprecise even before the trim — informational only.:340-455,:457,:60/:62) drifted 2-7 lines vs current install.sh; executed by content-anchoring. Notably the deletion had to start at the# ─── 3.5 …header comment (:333), not theecholine the plan names — else the test's own assertion 4 stays red.