docs(ssot): withdraw TaskMaster install from SSOT #84 (one-click-installer S4) - #449
Merged
Conversation
artyhoo
enabled auto-merge (squash)
June 10, 2026 18:17
artyhoo
added a commit
that referenced
this pull request
Jun 10, 2026
…non-fast-forward diagnosis (#455) Modes: every blob's tree entry hardcoded mode 100644, silently stripping the exec bit off executables and mispushing symlinks. Now the mode is resolved per path — git index (ls-files --stage) → HEAD (ls-tree) → filesystem bits fallback — so 100755 and 120000 survive; a symlink blob carries the link target string; gitlink/tree modes (160000/040000) are rejected loudly instead of being pushed as corrupt 100644 blobs. Ref edge: the branch-update PATCH {force:false} now diagnoses a 422 non-fast-forward explicitly — shows the moved remote tip and the new commit's actual parent, suggests re-run or a fresh --branch, and states it will NOT auto-force — instead of dying on a raw gh error. Found live while dogfooding this push: branch existence must key off gh's exit code, not stdout — on 404 `gh api --jq` prints the error body to stdout, so a non-empty-stdout check takes the PATCH path for absent branches (pinned in the test stub). Incidents (one-click-installer umbrella, 2026-06-10): the S4 pushes (#449-#451) required hand-editing the tree payload to preserve the repo-root `setup` script's 100755 mode, and the S5 push (#452) needed manual hand-holding of the force:false ref PATCH. Both adaptations are now parameterized and pinned by a paired-negative test (tests/dispatcher/harvest-via-api.test.sh — stubbed gh, no network), wired into audit-self.yml#principles-meta-tests. Prior-art: skipped — hardening + test for an existing helper, no new capability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Amends SSOT row #84 (
docs/meta-factory/prior-art-evaluations.md:154) with the TaskMaster-install withdrawal note, verbatim from plan Task 6 (docs/superpowers/plans/2026-05-31-one-click-installer.md, «Task 6: SSOT annotation») per one-click-installer kickoff §2 S4. Also bumps the row'sLast reviewedcell 2026-05-27 → 2026-06-10 per the register's field contract. Amendment of the existing row — no new numbered entry, no renumbering.Verify-trace
git branch --show-current→worktree-oci-s4-ssotgrep -c '^| 84 ' docs/meta-factory/prior-art-evaluations.md→1grep -n "withdrawn 2026-05-31" docs/meta-factory/prior-art-evaluations.md→ single hit, line 154 (row 84)grep '^| 84 ' … | grep -o '2026-05-27' | wc -l→3(was 4 — onlyLast reviewedchanged;First seen, probe date, and the2026-05-27-install-sh-k1-extension.mdcitation filename untouched)npx vitest run packages/core/principles/08-prior-art-cited.test.ts→ 1 file / 7 tests passednpx markdownlint-cli2 docs/meta-factory/prior-art-evaluations.md→Summary: 0 error(s)tests verified locally, CI wiring lands in S5
Scope
1 file:
docs/meta-factory/prior-art-evaluations.md(row #84 cell amendment + Last-reviewed bump). No capability commit — docs-only edit per the CLAUDE.md capability-commit definition (no new dependency, no new file underpackages/); noPrior-art:trailer required.Note (orchestrator): branch was recreated server-side via the Git Data API on top of staging HEAD
9c10c68(git SSH/HTTPS transport blocked by the known flaky tunnel; documented fallback). Local pre-push hooks therefore did not run on push — compensated by the worker's local principle-08 + markdownlint runs above and by CI on this PR.§1.7 Forward-check applied
docs/meta-factory/prior-art-evaluations.md:70): «Do not edit existing rows in place except forLast reviewedupdates per §3 step 1; substantive verdict changes are new commits with git history audit» — verdict cell (ADOPT) unchanged; the dated note append is the maintainer-approved plan-Task-6 amendment, and this commit is its git-history audit.Last reviewedbump per field spec (prior-art-evaluations.md:28).packages/core/principles/08-prior-art-cited.test.ts): run post-edit → 7/7 PASS (no broken SSOT references introduced)..claude/rules/doc-authority-hierarchy.md §3): no header change; row-cell edit only.prior-art-evaluations.md:143confirms row fix(hooks): aggregate full assistant turn for end-of-turn reminder #73 IS TaskMasteranalyze-complexity— the appended «SSOT fix(hooks): aggregate full assistant turn for end-of-turn reminder #73 (TM vocabulary) unaffected» reference is accurate.§1.7 Backward-check applied
Sweep:
grep -rni 'taskmaster|task-master'across README/INSTALL*/CLAUDE.md/docs/.claude/rules/packages/scripts/install.sh/setup*/agents (node_modules + SSOT excluded). Findings:README.md:121(«Optionally installs companion tools (Superpowers, TaskMaster) viaclaude plugin install»),README.md:127(«Install TaskMaster? [y/N]» prompt),README.md:131(COMPANIONS=superpowers,task-masterexample),README.md:136(«TaskMaster install (install.sh:411)» — line ref now dangling). These four still claim TM installs via install.sh — handled by the sibling S4-docs PR in this stage.2026-05-27-install-sh-k1-extension.md:81,2026-05-27-stage-5-install-sh-k1-verification.md:24) document the pre-withdrawal era; the design spec + plan (docs/superpowers/specs/2026-05-31-one-click-installer-design.md:101,docs/superpowers/plans/2026-05-31-one-click-installer.md:466) document the withdrawal itself — consistent.packages/core/skills/classify-work.test.ts:19attributes TaskMaster complexity tiers to «SSOT fix(hooks): add permission for end-of-turn-reminder Stop hook #72», but fix(hooks): add permission for end-of-turn-reminder Stop hook #72 is OpenHands (prior-art-evaluations.md:142); TaskMaster is fix(hooks): aggregate full assistant turn for end-of-turn reminder #73 (prior-art-evaluations.md:143) — stale ID in a test comment.