fix(final-quality-audit): de-inert shipped quality gates + audit patches (S1–S3) - #470
Merged
Conversation
…hes (S1-S3, 11 commits squashed) FQA umbrella S1 (4 audit research-patches + S2 consolidation plan) + S3 fixes: de-inert install.sh (eslint barrel gen / dep-cruiser / scripts merge / tool-decisions seed / single-source skill-context / context7 drop-but-insist), principle-15 git-aware, probe-cc-perm deletion, doc-currency. Flattened from 11 commits (84c2b44..da7fb46) — git transport blocked by proxy tunnel; pushed via GitHub Data API (api.github.com reachable, github.com:22/:443 not).
The FQA flatten (b6f2ab9) carried the pre-#464 audit-ai-docs.sh, silently reverting the AUDIT_MODE consumer-mode detection #464 added — so consumer installs ran D3/D5 (authoring-repo probes) and exited 1, failing tests/install-sh/audit-consumer-mode.test.sh (4 assertions). Restores the consumer-skip logic; keeps FQA's D4 warn-message tweak. All 14 Principles-job steps green locally on the faithful b6f2ab9 reconstruction. Prior-art: skipped — bug fix restoring dropped #464 logic, no new capability.
This was referenced Jun 13, 2026
artyhoo
added a commit
that referenced
this pull request
Jun 13, 2026
#495) * chore(orchestrator): close final-quality-audit umbrella (done.md) + §0 reconcile The FQA umbrella shipped S1–S3 in #470 (de-inert shipped quality gates + principle-15 git-aware + orphan deletions + doc-currency; DN-1..DN-4 resolved within S3) but was never formally closed and is absent from wave-sequencing-plan §0. /pipeline final-quality-audit plan-currency check surfaced the drift. - Write the missing `.claude/orchestrator-prompts/final-quality-audit/done.md` closure marker (Final PR #470). Executable closure evidence: `tests/install-sh/c1-wiring.test.sh` 10/10 incl. P1-neg/P1-pos paired-negative. - Reconcile §0 → 2026-06-13: add the FQA umbrella row + its `consumer-install- hardening` follow-on (✅ #491/#493); mark `guard-liveness` ✅ DONE (#484/#489) — all three were the 2026-06-11 open frontier, all closed today. - Rewrite open-frontier + «What actually remains» to «no active in-flight umbrella»; bump snapshot date + add revision-history entry. Prior-art: skipped — orchestrator bookkeeping (done.md closure marker + §0 plan reconciliation reflecting already-merged PRs), no new capability. * fix(orchestrator): full filename in FQA done.md (basename -f crash in dead-link check) The done.md referenced the S2 plan as shorthand `-fqa-s2-consolidation-plan.md` with a leading dash. audit-self.yml:104 dead-link check runs `basename "$ref"`, which parses a leading-dash arg as a flag → `basename: invalid option -- 'f'` → mechanical-checks job exit 1 → ci-success fails. Use the full filename `2026-06-11-fqa-s2-consolidation-plan.md` (also resolves the dead-link warning, since that file exists). Prior-art: skipped — one-line doc fix, no new capability. --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final-quality-audit (FQA) — S1 audits + S2 plan + S3 fixes
Full AI-stack audit commissioned 2026-06-11. Stage 1 (4 read-only audits) → Stage 2 (consolidation plan) → Stage 3 (4 fix clusters). Independently corroborated by the
timelinerconsumer audit (CONSUMER-FINDINGS-timeliner.md). Flattened from 11 commits (84c2b44..da7fb46) — git transport was blocked by the proxy tunnel; pushed via the GitHub Data API (api.github.comreachable,github.com:22/:443not).What changed
docs/meta-factory/research-patches/2026-06-11-fqa-{a,b,c,d}-*.md+-s2-consolidation-plan.md): the 4 Stage-1 audits + the consolidated fix-plan. Headline finding: the installer shipped rule files + a CI shell but not the wiring → rules were inert in consumers (project thesis violated in its own product).install.sh: generate theeslint-rules-local/index.tsbarrel the config imports (W1); ship.dependency-cruiser.cjs(W2); non-destructively merge canonicalpackage.jsonscripts (W4); seed.ai-factory/tool-decisions.mdwith the<pending>sentinel so the deps-change hook fires (P1, paired-negative test); single-source skill-context viaSHIPPED_DOCSso all 3 land (P2); context7 drop-but-insist intool-bootstrapping/SKILL.md§3 + template (P3, DN-2);audit-ai-docs.shremediation de-legacy (F-A).packages/core/principles/15-skill-paired-negative.test.ts: git-awareenumerateSkills()(no false-RED on installer-populated clones).probe-cc-permskill.tests/install-sh/c1-wiring.test.sh(10/10) — incl. the P1 paired-negative (no seed → hook silent; seed → WARN).Reviewer should know
install.shon bothts-server+react-next(rc=0); principle suite 170/171 (the 1 red is pre-existing principle-12 on 6 unrelated gitignored kickoffs, CI-skipped); all 6 existing install-sh suites + the new one green; principle 09/10/13/15 green.npm installs the tools). Both routed to the follow-upconsumer-install-hardeningumbrella, which also carries the W3/audit-r4 correction (FQA wrongly dropped it; the timeliner audit F6 provedaudit-ai-docs.sh:83calls it).§1.7 Forward-check applied
Checked this change set against the active disciplines before shipping; all comply.
no-paid-llm-in-ci.md— all audit probes + the install-sh test are deterministic bash, zero API-billed calls. file:line evidence:tests/install-sh/c1-wiring.test.sh:1doc-authority-hierarchy.md— research-patches carry principle-10 scope annotations; no Authoritative-for headers altered. file:line evidence:docs/meta-factory/research-patches/2026-06-11-fqa-a-shipped-surface.md:1build-first-reuse-default.md— no new deps/capabilities; reuses git, node, existing templates + the install-sh test harness. Verdict: REUSE, compliant.phase-research-coverage.md §1.12— each fix carries an executable acceptance, not a prose claim. file:line evidence:packages/core/principles/15-skill-paired-negative.test.ts:113§1.7 Backward-check applied
Swept the existing artefacts under each change's scope; nothing silently superseded.
install.shSHIPPED_DOCS ↔ principle-09 — single-source kept the 17-entry literal static-parseable; principle 09 stays 23/23. file:line evidence:install.sh:95packages/core/principles/15-skill-paired-negative.test.ts— git-aware filter narrows scope to tracked skills; the tracked surface is still audited (>0 assert holds), paired-negative intact. file:line evidence:packages/core/principles/15-skill-paired-negative.test.ts:121agents/living-docs-auditor.md— only the stale self-name on line 159 changed; the intentional rename-history mentions (lines 2/3/9) preserved. file:line evidence:agents/living-docs-auditor.md:159.claude/rules/dual-implementation-discipline.md— dangling skill ref corrected to a source-resident example; rule semantics unchanged. file:line evidence:.claude/rules/dual-implementation-discipline.md:65