Skip to content

WorkspaceService fixes / Personal notifications#127

Merged
das-Abroxas merged 38 commits intodevfrom
feat/version2.0rework
Oct 16, 2023
Merged

WorkspaceService fixes / Personal notifications#127
das-Abroxas merged 38 commits intodevfrom
feat/version2.0rework

Conversation

@das-Abroxas
Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas commented Oct 16, 2023

This update includes the final feature implementations and bugfixes in preparation for the ArunaServer 2.0.0-rc.1 release.

Features:

  • Cache does not remove objects anymore on deletion
  • Implement persistent notifications for users including tests
  • Added partly implemented DataProxyService mock to test environment

Bugfixes:

  • WorkspaceService SQL queries
  • WorksapceService tests

das-Abroxas and others added 30 commits September 28, 2023 13:36
@das-Abroxas
feat: Extend database schema for persistent notifications
f9ef688
@das-Abroxas
refactor: Cache remove object
8649fff 
The remove object function now behaves analog to the database delete
object and only sets the objects status to 'Deleted' instead of
removing it from the cache.
@lfbrehm
fix: Workspace requests
4e4c499
@das-Abroxas
feat: Implement persistent notification dsl
8a140c7
@das-Abroxas
feat: Implement UserService functions
6051da3 
These are functions regarding personal notifications which are stored
persistently in the database. These notifications can only be pulled and
acknowledged by the users themselves.
@das-Abroxas
fix: PersistentNotification attribute names
a834a9b
@das-Abroxas
test: Add persisten notification db test
5b7edfe
@das-Abroxas
feat: Implement SearchService request_resource_access
05021d0
@das-Abroxas
chore: Add another normal user to initial data
3a4da2a
@das-Abroxas
feat: Add check that user id from request and token match
5ec591a
@lfbrehm
feat: Workspace tests and endpoint mock for tests
12f26de
@lfbrehm
chore: Updated dependencies and clippy suggestions
bc566ca
@lfbrehm
fix: Fixed claim workspace request
afe7bfb
@das-Abroxas
feat: Add flag to control persistent notification creation
96fc548
@das-Abroxas
chore: Changed personal notification message templates
4941fe7
@das-Abroxas
chore: Added second user to initial test data
57ecc41
@das-Abroxas
chore: Added SearchService to test service init
f963824
@das-Abroxas
test: Added personal notification gRPC tests
522c1a2
@das-Abroxas
test: Add request resource access gRPC test
a6a5f91
@das-Abroxas
fix: Incorrect order of provided parameters
ec9fd92
@das-Abroxas
fix: Broken test assert
9e59b58
@das-Abroxas
Merge remote-tracking branch 'origin/feat/version2.0rework' into feat…
b315906 
…/personal-notifications
@das-Abroxas
chore: Cargo clippy fixes and cargo fmt
86568f6
@das-Abroxas
merge: Merge pull request #124 from ArunaStorage/feat/personal-notifi…
3ff0424 
…cations

Personal notifications
@lfbrehm
fix: Fixed workspace db query
f9932f2
@das-Abroxas
feat: Extend dataproxy token creation
80393e9 
Registered users are now able to create tokens without specific
intent for direct communication with Dataproxies.
@lfbrehm
fix: Fixed Dockerfile and added config value for issuers
de17e7e
@lfbrehm
feat: Mock dataproxys can abort()
bbbe022
@lfbrehm
merge: Merge branch 'feat/version2.0rework' into feat/v2_workspaces
9c9fa92
@lfbrehm
fix: Fixed cargo fmt --check
1ba32d0
@das-Abroxas das-Abroxas added the enhancement New feature or request label Oct 16, 2023
@das-Abroxas das-Abroxas requested review from St4NNi and lfbrehm October 16, 2023 06:50
@das-Abroxas das-Abroxas self-assigned this Oct 16, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2023

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Comparison is base (9226988) 46.93% compared to head (02a83d6) 52.31%.
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #127      +/-   ##
==========================================
+ Coverage   46.93%   52.31%   +5.37%     
==========================================
  Files          69       70       +1     
  Lines       10028    10320     +292     
==========================================
+ Hits         4707     5399     +692     
+ Misses       5321     4921     -400
Files Coverage Δ
src/database/dsls/mod.rs 100.00% <ø> (ø)
src/database/enums.rs 78.12% <100.00%> (+0.95%) ⬆️
src/grpc/authorization.rs 97.24% <100.00%> (+0.02%) ⬆️
src/grpc/hooks.rs 0.00% <ø> (ø)
src/grpc/workspaces.rs 0.00% <ø> (ø)
src/middlelayer/create_db_handler.rs 73.45% <100.00%> (+0.23%) ⬆️
src/middlelayer/token_db_handler.rs 29.11% <100.00%> (+29.11%) ⬆️
src/middlelayer/workspace_db_handler.rs 92.26% <100.00%> (+92.26%) ⬆️
src/main.rs 0.67% <0.00%> (ø)
src/search/meilisearch_client.rs 45.14% <0.00%> (-6.89%) ⬇️
... and 9 more

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lfbrehm
lfbrehm approved these changes Oct 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@das-Abroxas das-Abroxas marked this pull request as ready for review October 16, 2023 11:45
@das-Abroxas das-Abroxas merged commit 2d45ae8 into dev Oct 16, 2023
@St4NNi St4NNi deleted the feat/version2.0rework branch October 20, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lfbrehm lfbrehm lfbrehm approved these changes

@St4NNi St4NNi Awaiting requested review from St4NNi

Assignees

@das-Abroxas das-Abroxas

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@das-Abroxas @lfbrehm